LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dave Young" <hidave.darkstar@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@elte.hu>
Subject: Re: [BUG] using smp_processor_id() in preemptible as suspending
Date: Wed, 27 Feb 2008 09:04:55 +0800	[thread overview]
Message-ID: <a8e1da0802261704t34eae4b9q758d22ee88fff3a9@mail.gmail.com> (raw)
In-Reply-To: <20080226194504.GC8395@linux.vnet.ibm.com>

On Wed, Feb 27, 2008 at 3:45 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> On Tue, Feb 26, 2008 at 08:33:54AM -0800, Andrew Morton wrote:
>  > On Tue, 26 Feb 2008 16:24:11 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
>  >
>  > > I don't know whom I should mail to, could you cc the proper guy? Thanks.
>
>  Hello, Dave,
>
>  Would you be willing to try out the following (untested, might not even
>  compile) patch show at the very end of this message?  This assumes that
>  you were running with CONFIG_PREEMPT_RCU, which seems most likely based
>  on looking at your oops.

Built ok, but can't even resume now. (dark screen with cursor blinking
on top-left of minitor)

Forgot to tell, I saw this bug as enable PM_DEBUG, maybe it's related
to PM issue?

>
>                                                         Thanx, Paul
>
>
>
>  > > [  118.331674] acpi LNXSYSTM:00: suspend
>  > > [  118.331674] Disabling non-boot CPUs ...
>  > > [  118.331674] CPU0 attaching NULL sched-domain.
>  > > [  118.331674] CPU1 attaching NULL sched-domain.
>  > > [  118.438750] CPU 1 is now offline
>  > > [  118.438750] lockdep: fixing up alternatives.
>  > > [  118.438750] SMP alternatives: switching to UP code
>  > > [  118.438750] BUG: using smp_processor_id() in preemptible [00000000] code: s2ram/2818
>  > > [  118.438750] caller is rcu_offline_cpu+0x15a/0x1c0
>  > > [  118.438750] Pid: 2818, comm: s2ram Not tainted 2.6.25-rc3-test #2
>  > > [  118.438750]  [<c0129738>] ? printk+0x18/0x20
>  > > [  118.438750]  [<c025c551>] debug_smp_processor_id+0xb1/0xc0
>  > > [  118.438750]  [<c0161f8a>] rcu_offline_cpu+0x15a/0x1c0
>  > > [  118.438750]  [<c03d408f>] rcu_cpu_notify+0x3f/0x60
>  > > [  118.438750]  [<c0141b0d>] notifier_call_chain+0x3d/0x80
>  > > [  118.438750]  [<c0141db9>] __raw_notifier_call_chain+0x19/0x20
>  > > [  118.438750]  [<c0141dda>] raw_notifier_call_chain+0x1a/0x20
>  > > [  118.438750]  [<c015262b>] _cpu_down+0x13b/0x230
>  > > [  118.438750]  [<c01527c9>] disable_nonboot_cpus+0x49/0xd0
>  > > [  118.438750]  [<c0157492>] suspend_devices_and_enter+0x72/0x130
>  > > [  118.438750]  [<c0129738>] ? printk+0x18/0x20
>  > > [  118.438750]  [<c0157623>] enter_state+0xb3/0xe0
>  > > [  118.438750]  [<c015777d>] state_store+0x7d/0xc0
>  > > [  118.438750]  [<c0157700>] ? state_store+0x0/0xc0
>  > > [  118.438750]  [<c0249e4e>] kobj_attr_store+0x2e/0x40
>  > > [  118.438750]  [<c01ca957>] flush_write_buffer+0x47/0x70
>  > > [  118.438750]  [<c01ca9c9>] sysfs_write_file+0x49/0x70
>  > > [  118.438750]  [<c0188d41>] vfs_write+0x91/0x140
>  > > [  118.438750]  [<c0188e9d>] sys_write+0x3d/0x70
>  > > [  118.438750]  [<c0104fca>] syscall_call+0x7/0xb
>  > > [  118.438750]  =======================
>  > > [  118.438750] CPU0 attaching NULL sched-domain.
>  > > [  118.440335] CPU1 is down
>  >
>  > Paul & Ingo I guess
>  >
>  > > My .config
>  >
>  > Doesn't tell us whether you'r eusing CONFIG_CLASSIC_RCU or
>  > CONFIG_PREEMPT_RCU.  I assume CONFIG_CLASSIC_RCU, if you ran `make
>  > oldconfig'.
>  >
>  > Which kernel are you running here?
>
>  Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>  ---
>
>   rcupreempt.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>  diff -urpNa -X dontdiff linux-2.6.25-rc2/kernel/rcupreempt.c linux-2.6.25-rc2-rcuoffline/kernel/rcupreempt.c
>  --- linux-2.6.25-rc2/kernel/rcupreempt.c        2008-02-24 10:30:44.000000000 -0800
>  +++ linux-2.6.25-rc2-rcuoffline/kernel/rcupreempt.c     2008-02-26 11:39:33.000000000 -0800
>  @@ -702,8 +702,8 @@ void rcu_offline_cpu(int cpu)
>          * fix.
>          */
>
>  -       rdp = RCU_DATA_ME();
>         spin_lock_irqsave(&rdp->lock, flags);
>  +       rdp = RCU_DATA_ME();
>         *rdp->nexttail = list;
>         if (list)
>                 rdp->nexttail = tail;
>

  reply	other threads:[~2008-02-27  1:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26  8:24 Dave Young
2008-02-26 16:33 ` Andrew Morton
2008-02-26 19:45   ` Paul E. McKenney
2008-02-27  1:04     ` Dave Young [this message]
2008-02-27 23:11       ` Karsten Wiese
2008-02-28  0:26         ` Paul E. McKenney
2008-02-27  0:39   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0802261704t34eae4b9q758d22ee88fff3a9@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    --subject='Re: [BUG] using smp_processor_id() in preemptible as suspending' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).