LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dave Young" <hidave.darkstar@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Johannes Weiner" <hannes@saeurebad.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] add time_now_after and other macros which compare with jiffies
Date: Mon, 10 Mar 2008 10:03:47 +0800	[thread overview]
Message-ID: <a8e1da0803091903i3ea7a54bkea797a43eeae462e@mail.gmail.com> (raw)
In-Reply-To: <20080309120133.2d1363e4.akpm@linux-foundation.org>

On Mon, Mar 10, 2008 at 3:01 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sun, 9 Mar 2008 11:08:08 +0000 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
>  > > Yes, This has a purpose as well. You will find most of the usage of these
>  > > macros are just compare some value with jiffies after doing some grep.
>  >
>  > That is no reason to add more macros that hide how they do it, or make
>  > jiffies itself invisible to the grep search or variable usage finding
>  > tools (and for tickless that very thing is important)
>
>  We could call them time_is_after_jiffies(), time_is_before_jiffies(), etc.
>
>  Those names are actually better than time_after_now(), etc.
>
>
Andrew, Hannes, Alan,
thanks for your comment, I have send the new time_is_* patch as v3.

Hannes, It's more like your is_past/is_future but looks better when
along with _eq

  parent reply	other threads:[~2008-03-10  2:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-07 23:35 Dave Young
2008-03-08 16:12 ` Johannes Weiner
2008-03-09  0:54   ` Dave Young
2008-03-09  9:58     ` Alan Cox
2008-03-09 10:44       ` Dave Young
2008-03-09 11:08         ` Alan Cox
2008-03-09 19:01           ` Andrew Morton
2008-03-09 20:06             ` Alan Cox
2008-03-10  2:03             ` Dave Young [this message]
2008-03-10  2:41               ` Johannes Weiner
2008-03-09 18:36       ` Andrew Morton
2008-03-09 20:03         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0803091903i3ea7a54bkea797a43eeae462e@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hannes@saeurebad.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2] add time_now_after and other macros which compare with jiffies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).