LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dave Young" <hidave.darkstar@gmail.com>
To: "Folkert van Heusden" <folkert@vanheusden.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6.26] OOPS in elv_next_request
Date: Tue, 28 Oct 2008 13:11:30 +0800	[thread overview]
Message-ID: <a8e1da0810272211s4b145bboef26801c3af0d652@mail.gmail.com> (raw)
In-Reply-To: <20081027090426.GN8318@vanheusden.com>

[-- Attachment #1: Type: text/plain, Size: 3099 bytes --]

On Mon, Oct 27, 2008 at 5:04 PM, Folkert van Heusden
<folkert@vanheusden.com> wrote:
> Hi,
>
> While running my http://vanheusden.com/pyk/ script (which randomly
> inserts and removes modules) I triggered the folllowing oops in a 2.6.26
> kernel on a Celeron 400 (Mendocino):
>
> [ 4768.664021] Floppy drive(s): fd0 is 1.44M
> [ 4768.682751] FDC 0 is a post-1991 82077
> [ 4768.717031] work still pending
> [ 4768.718486] BUG: unable to handle kernel NULL pointer dereference at 00000010
> [ 4768.718711] IP: [<c01d073f>] elv_next_request+0x17e/0x18e
> [ 4768.718898] *pde = 00000000
> [ 4768.719035] Oops: 0000 [#1] SMP
> [ 4768.719210] Modules linked in: floppy(-) pcspkr gspca shpchp cdrom battery ata_generic libata pci_hotplug gameport snd_rawmidi parport hwmon_vid scsi_mod videodev v4l1_compat dock ipv6 loop snd_seq_device snd_timer snd soundcore via_agp agpgart evdev ext3 jbd mbcache ide_disk via82cxxx ide_pci_generic ide_core 8139too usbcore 8139cp mii processor thermal_sys [last unloaded: floppy]
> [ 4768.720058]
> [ 4768.720058] Pid: 6, comm: events/0 Not tainted (2.6.26-1-686 #1)
> [ 4768.720058] EIP: 0060:[<c01d073f>] EFLAGS: 00010046 CPU: 0
> [ 4768.720058] EIP is at elv_next_request+0x17e/0x18e
> [ 4768.720058] EAX: c872c078 EBX: c940a820 ECX: 00000000 EDX: 00000000
> [ 4768.720058] ESI: c872c078 EDI: ca964f48 EBP: 00000000 ESP: c943ff50
> [ 4768.720058]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
> [ 4768.720058] Process events/0 (pid: 6, ti=c943e000 task=c942a460 task.ti=c943e000)
> [ 4768.720058] Stack: c940a820 c940a820 ca96b494 ca964f48 ca964f91 c58ce5c0 c942a460 c02b7ec7
> [ 4768.720058]        c9443500 4bcc15bb 00000456 c942a5ec c1148fa0 00000000 c940a820 ca96b494
> [ 4768.720058]        000018e7 00000000 c940a820 ca96b494 ca964f48 00000000 c012edee c940a820
> [ 4768.720058] Call Trace:
> [ 4768.720058]  [<ca964f48>] redo_fd_request+0x0/0xc5d [floppy]
> [ 4768.720058]  [<ca964f91>] redo_fd_request+0x49/0xc5d [floppy]
> [ 4768.720058]  [<c02b7ec7>] schedule+0x63d/0x66f
> [ 4768.720058]  [<ca964f48>] redo_fd_request+0x0/0xc5d [floppy]
> [ 4768.720058]  [<c012edee>] run_workqueue+0x74/0xf2
> [ 4768.720058]  [<c012f4c9>] worker_thread+0x0/0xbd
> [ 4768.720058]  [<c012f57c>] worker_thread+0xb3/0xbd
> [ 4768.720058]  [<c013177c>] autoremove_wake_function+0x0/0x2d
> [ 4768.720058]  [<c01316bb>] kthread+0x38/0x5d
> [ 4768.720058]  [<c0131683>] kthread+0x0/0x5d
> [ 4768.720058]  [<c01044f3>] kernel_thread_helper+0x7/0x10
> [ 4768.720058]  =======================
> [ 4768.720058] Code: 06 89 e2 89 04 24 89 f0 e8 a9 37 00 00 85 c0 74 0d 8b 1c 24 85 db 0f 85 9e fe ff ff eb 16 39 36 75 dd 8b 46 0c 31 d2 8b 08 89 f0 <ff> 51 10 85 c0 75 ec 31 db 5f 89 d8 5b 5e 5f c3 55 89 cd 57 89
> [ 4768.720058] EIP: [<c01d073f>] elv_next_request+0x17e/0x18e SS:ESP 0068:c943ff50
> [ 4768.720058] ---[ end trace 6a50caff78c47574 ]---
> [ 4769.658313] Floppy drive(s): fd0 is 1.44M
> [ 4789.656060] no cont in shutdown!
>
>

Hi, could you try the attached test patch?  sorry for using attachment
as there's some problem for my mail client to reply.

-- 
Regards
dave

[-- Attachment #2: floppy_flush_workqueue_before_release.patch --]
[-- Type: application/octet-stream, Size: 325 bytes --]

--- linux-2.6.27.orig/drivers/block/floppy.c	2008-10-10 06:13:53.000000000 +0800
+++ linux-2.6.27/drivers/block/floppy.c	2008-10-28 13:05:45.000000000 +0800
@@ -4557,6 +4557,7 @@
 	del_timer_sync(&fd_timer);
 	blk_cleanup_queue(floppy_queue);
 
+	flush_scheduled_work();
 	if (usage_count)
 		floppy_release_irq_and_dma();
 

  reply	other threads:[~2008-10-28  5:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-27  9:04 Folkert van Heusden
2008-10-28  5:11 ` Dave Young [this message]
2008-10-28 15:05   ` Folkert van Heusden
2008-10-30 14:25   ` Folkert van Heusden
2008-10-31  1:22     ` Dave Young
2008-10-31 10:03       ` Folkert van Heusden
2008-11-01 16:12       ` Folkert van Heusden
2008-11-12  2:30         ` Dave Young
2008-11-16 12:36           ` Folkert van Heusden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8e1da0810272211s4b145bboef26801c3af0d652@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=folkert@vanheusden.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [2.6.26] OOPS in elv_next_request' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).