LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type
@ 2018-04-19  2:00 Baolin Wang
  2018-04-19  2:00 ` [PATCH v2 2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Baolin Wang @ 2018-04-19  2:00 UTC (permalink / raw)
  To: dan.j.williams, vinod.koul
  Cc: eric.long, broonie, dmaengine, linux-kernel, baolin.wang

From: Eric Long <eric.long@spreadtrum.com>

Define the DMA transfer step type to make code more readable.

Signed-off-by: Eric Long <eric.long@spreadtrum.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
Changes since v1:
 - Convert enum structure to macros definition for DMA step type.
---
 drivers/dma/sprd-dma.c |   19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index b106e8a..dcfa417 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -116,6 +116,13 @@
 #define SPRD_DMA_SRC_TRSF_STEP_OFFSET	0
 #define SPRD_DMA_TRSF_STEP_MASK		GENMASK(15, 0)
 
+/* define the DMA transfer step type */
+#define SPRD_DMA_NONE_STEP		0
+#define SPRD_DMA_BYTE_STEP		1
+#define SPRD_DMA_SHORT_STEP		2
+#define SPRD_DMA_WORD_STEP		4
+#define SPRD_DMA_DWORD_STEP		8
+
 #define SPRD_DMA_SOFTWARE_UID		0
 
 /*
@@ -598,16 +605,16 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
 
 	if (IS_ALIGNED(len, 4)) {
 		datawidth = 2;
-		src_step = 4;
-		des_step = 4;
+		src_step = SPRD_DMA_WORD_STEP;
+		des_step = SPRD_DMA_WORD_STEP;
 	} else if (IS_ALIGNED(len, 2)) {
 		datawidth = 1;
-		src_step = 2;
-		des_step = 2;
+		src_step = SPRD_DMA_SHORT_STEP;
+		des_step = SPRD_DMA_SHORT_STEP;
 	} else {
 		datawidth = 0;
-		src_step = 1;
-		des_step = 1;
+		src_step = SPRD_DMA_BYTE_STEP;
+		des_step = SPRD_DMA_BYTE_STEP;
 	}
 
 	fragment_len = SPRD_DMA_MEMCPY_MIN_SIZE;
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-04-30  8:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  2:00 [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-19  2:00 ` [PATCH v2 2/5] dmaengine: sprd: Define the DMA data width type Baolin Wang
2018-04-27  6:25   ` Vinod Koul
2018-04-19  2:00 ` [PATCH v2 3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang
2018-04-27  6:26   ` Vinod Koul
2018-04-19  2:00 ` [PATCH v2 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-27  6:24   ` Vinod Koul
2018-04-30  8:18     ` Baolin Wang
2018-04-19  2:00 ` [PATCH v2 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-27  6:25 ` [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).