LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
@ 2018-10-30 11:56 Colin King
2018-10-30 11:57 ` Colin Ian King
2018-10-30 15:41 ` Gross, Mark
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2018-10-30 11:56 UTC (permalink / raw)
To: Mark Gross, Arnd Bergmann, Greg Kroah-Hartman
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to clean up an indentation issue, remove tabs
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index 8eeb4190207d..a0f2c0506176 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -506,27 +506,27 @@ static ssize_t store_select_amcb2_transmit_clock(struct device *d,
val = (unsigned char)tmp;
spin_lock_irqsave(&event_lock, flags);
- if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
- SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
- SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
- } else if (val >= CLK_8_592MHz) {
- SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
- switch (val) {
- case CLK_8_592MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
- break;
- case CLK_11_184MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
- break;
- case CLK_34_368MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
- break;
- case CLK_44_736MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
- break;
- }
- } else
- SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
+ if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
+ SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
+ SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
+ } else if (val >= CLK_8_592MHz) {
+ SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
+ switch (val) {
+ case CLK_8_592MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
+ break;
+ case CLK_11_184MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
+ break;
+ case CLK_34_368MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
+ break;
+ case CLK_44_736MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
+ break;
+ }
+ } else
+ SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
spin_unlock_irqrestore(&event_lock, flags);
@@ -548,27 +548,27 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,
val = (unsigned char)tmp;
spin_lock_irqsave(&event_lock, flags);
- if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
- SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
- SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
- } else if (val >= CLK_8_592MHz) {
- SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
- switch (val) {
- case CLK_8_592MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
- break;
- case CLK_11_184MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
- break;
- case CLK_34_368MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
- break;
- case CLK_44_736MHz:
- SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
- break;
- }
- } else
- SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
+ if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
+ SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
+ SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
+ } else if (val >= CLK_8_592MHz) {
+ SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
+ switch (val) {
+ case CLK_8_592MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
+ break;
+ case CLK_11_184MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
+ break;
+ case CLK_34_368MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
+ break;
+ case CLK_44_736MHz:
+ SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
+ break;
+ }
+ } else
+ SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
spin_unlock_irqrestore(&event_lock, flags);
return strnlen(buf, count);
--
2.19.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
2018-10-30 11:56 [PATCH] tlclk: lean an indentation issue, remove extraneous tabs Colin King
@ 2018-10-30 11:57 ` Colin Ian King
2018-10-31 18:05 ` Joe Perches
2018-10-30 15:41 ` Gross, Mark
1 sibling, 1 reply; 4+ messages in thread
From: Colin Ian King @ 2018-10-30 11:57 UTC (permalink / raw)
To: Mark Gross, Arnd Bergmann, Greg Kroah-Hartman
Cc: kernel-janitors, linux-kernel
$SUBJECT should be:
tlclk: clean an indentation issue, remove extraneous tabs
On 30/10/2018 11:56, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to clean up an indentation issue, remove tabs
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
> index 8eeb4190207d..a0f2c0506176 100644
> --- a/drivers/char/tlclk.c
> +++ b/drivers/char/tlclk.c
> @@ -506,27 +506,27 @@ static ssize_t store_select_amcb2_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
>
> spin_unlock_irqrestore(&event_lock, flags);
>
> @@ -548,27 +548,27 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> spin_unlock_irqrestore(&event_lock, flags);
>
> return strnlen(buf, count);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
2018-10-30 11:56 [PATCH] tlclk: lean an indentation issue, remove extraneous tabs Colin King
2018-10-30 11:57 ` Colin Ian King
@ 2018-10-30 15:41 ` Gross, Mark
1 sibling, 0 replies; 4+ messages in thread
From: Gross, Mark @ 2018-10-30 15:41 UTC (permalink / raw)
To: Colin King, Arnd Bergmann, Greg Kroah-Hartman
Cc: kernel-janitors, linux-kernel
Looks cool to me.
Reviewed-by <mark.gross@intel.com>
--mark
> -----Original Message-----
> From: Colin King [mailto:colin.king@canonical.com]
> Sent: Tuesday, October 30, 2018 4:57 AM
> To: Gross, Mark <mark.gross@intel.com>; Arnd Bergmann <arnd@arndb.de>;
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to clean up an indentation issue, remove tabs
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/tlclk.c | 84 ++++++++++++++++++++++----------------------
> 1 file changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index
> 8eeb4190207d..a0f2c0506176 100644
> --- a/drivers/char/tlclk.c
> +++ b/drivers/char/tlclk.c
> @@ -506,27 +506,27 @@ static ssize_t
> store_select_amcb2_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
>
> spin_unlock_irqrestore(&event_lock, flags);
>
> @@ -548,27 +548,27 @@ static ssize_t
> store_select_amcb1_transmit_clock(struct device *d,
>
> val = (unsigned char)tmp;
> spin_lock_irqsave(&event_lock, flags);
> - if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> - SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> - } else if (val >= CLK_8_592MHz) {
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> - switch (val) {
> - case CLK_8_592MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> - break;
> - case CLK_11_184MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> - break;
> - case CLK_34_368MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> - break;
> - case CLK_44_736MHz:
> - SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> - break;
> - }
> - } else
> - SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> + } else if (val >= CLK_8_592MHz) {
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> + switch (val) {
> + case CLK_8_592MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> + break;
> + case CLK_11_184MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> + break;
> + case CLK_34_368MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> + break;
> + case CLK_44_736MHz:
> + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> + break;
> + }
> + } else
> + SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
> spin_unlock_irqrestore(&event_lock, flags);
>
> return strnlen(buf, count);
> --
> 2.19.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs
2018-10-30 11:57 ` Colin Ian King
@ 2018-10-31 18:05 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2018-10-31 18:05 UTC (permalink / raw)
To: Colin Ian King, Mark Gross, Arnd Bergmann, Greg Kroah-Hartman
Cc: kernel-janitors, linux-kernel
On Tue, 2018-10-30 at 11:57 +0000, Colin Ian King wrote:
> $SUBJECT should be:
>
> tlclk: clean an indentation issue, remove extraneous tabs
Perhaps add missing braces for the last else uses as well?
> On 30/10/2018 11:56, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
[]
> > diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
[]
> > + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x28);
> > + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> > + } else if (val >= CLK_8_592MHz) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xc7, 0x38);
> > + switch (val) {
> > + case CLK_8_592MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> > + break;
> > + case CLK_11_184MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> > + break;
> > + case CLK_34_368MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> > + break;
> > + case CLK_44_736MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);.
> > + break;
> > + }
> > + } else
> > + SET_PORT_BITS(TLCLK_REG3, 0xc7, val << 3);
here.
> > @@ -548,27 +548,27 @@ static ssize_t store_select_amcb1_transmit_clock(struct device *d,
[]
> > + if ((val == CLK_8kHz) || (val == CLK_16_384MHz)) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x5);
> > + SET_PORT_BITS(TLCLK_REG1, 0xfb, ~val);
> > + } else if (val >= CLK_8_592MHz) {
> > + SET_PORT_BITS(TLCLK_REG3, 0xf8, 0x7);
> > + switch (val) {
> > + case CLK_8_592MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 2);
> > + break;
> > + case CLK_11_184MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 0);
> > + break;
> > + case CLK_34_368MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 3);
> > + break;
> > + case CLK_44_736MHz:
> > + SET_PORT_BITS(TLCLK_REG0, 0xfc, 1);
> > + break;
> > + }
> > + } else
> > + SET_PORT_BITS(TLCLK_REG3, 0xf8, val);
and here.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-31 18:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 11:56 [PATCH] tlclk: lean an indentation issue, remove extraneous tabs Colin King
2018-10-30 11:57 ` Colin Ian King
2018-10-31 18:05 ` Joe Perches
2018-10-30 15:41 ` Gross, Mark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).