LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
@ 2018-04-24 15:00 Andy Shevchenko
  2018-04-25 10:25 ` Mika Westerberg
  2018-05-18 13:51 ` Lee Jones
  0 siblings, 2 replies; 7+ messages in thread
From: Andy Shevchenko @ 2018-04-24 15:00 UTC (permalink / raw)
  To: Lee Jones, linux-kernel; +Cc: Andy Shevchenko, Mika Westerberg

According to documentation REMAP register has to be programmed in
either DMA or PIO mode of the slice.

Move the DMA capability check below to let REMAP register be programmed
in PIO mode.

Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 9e545eb6e8b4..4bcf117a7ba8 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -275,11 +275,11 @@ static void intel_lpss_init_dev(const struct intel_lpss *lpss)
 
 	intel_lpss_deassert_reset(lpss);
 
+	intel_lpss_set_remap_addr(lpss);
+
 	if (!intel_lpss_has_idma(lpss))
 		return;
 
-	intel_lpss_set_remap_addr(lpss);
-
 	/* Make sure that SPI multiblock DMA transfers are re-enabled */
 	if (lpss->type == LPSS_DEV_SPI)
 		writel(value, lpss->priv + LPSS_PRIV_SSP_REG);
-- 
2.17.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
  2018-04-24 15:00 [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode Andy Shevchenko
@ 2018-04-25 10:25 ` Mika Westerberg
  2018-05-18 10:17   ` Andy Shevchenko
  2018-05-18 13:51 ` Lee Jones
  1 sibling, 1 reply; 7+ messages in thread
From: Mika Westerberg @ 2018-04-25 10:25 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Lee Jones, linux-kernel

On Tue, Apr 24, 2018 at 06:00:10PM +0300, Andy Shevchenko wrote:
> According to documentation REMAP register has to be programmed in
> either DMA or PIO mode of the slice.
> 
> Move the DMA capability check below to let REMAP register be programmed
> in PIO mode.
> 
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
  2018-04-25 10:25 ` Mika Westerberg
@ 2018-05-18 10:17   ` Andy Shevchenko
  2018-05-18 13:47     ` Lee Jones
  0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2018-05-18 10:17 UTC (permalink / raw)
  To: Mika Westerberg; +Cc: Lee Jones, linux-kernel

On Wed, 2018-04-25 at 13:25 +0300, Mika Westerberg wrote:
> On Tue, Apr 24, 2018 at 06:00:10PM +0300, Andy Shevchenko wrote:
> > According to documentation REMAP register has to be programmed in
> > either DMA or PIO mode of the slice.
> > 
> > Move the DMA capability check below to let REMAP register be
> > programmed
> > in PIO mode.
> > 
> > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > devices")
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Lee, can we have this applied in next rc cycle?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
  2018-05-18 10:17   ` Andy Shevchenko
@ 2018-05-18 13:47     ` Lee Jones
  0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2018-05-18 13:47 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: Mika Westerberg, linux-kernel

On Fri, 18 May 2018, Andy Shevchenko wrote:

> On Wed, 2018-04-25 at 13:25 +0300, Mika Westerberg wrote:
> > On Tue, Apr 24, 2018 at 06:00:10PM +0300, Andy Shevchenko wrote:
> > > According to documentation REMAP register has to be programmed in
> > > either DMA or PIO mode of the slice.
> > > 
> > > Move the DMA capability check below to let REMAP register be
> > > programmed
> > > in PIO mode.
> > > 
> > > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > > devices")
> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > 
> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Lee, can we have this applied in next rc cycle?

This has been broken since v4.3.

We'll roll it into v4.18 and tag it for -stable.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
  2018-04-24 15:00 [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode Andy Shevchenko
  2018-04-25 10:25 ` Mika Westerberg
@ 2018-05-18 13:51 ` Lee Jones
  2018-06-01  7:50   ` Andy Shevchenko
  1 sibling, 1 reply; 7+ messages in thread
From: Lee Jones @ 2018-05-18 13:51 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-kernel, Mika Westerberg

On Tue, 24 Apr 2018, Andy Shevchenko wrote:

> According to documentation REMAP register has to be programmed in
> either DMA or PIO mode of the slice.
> 
> Move the DMA capability check below to let REMAP register be programmed
> in PIO mode.
> 
> Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/intel-lpss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied and tagged for -stable # 4.3+

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
  2018-05-18 13:51 ` Lee Jones
@ 2018-06-01  7:50   ` Andy Shevchenko
  2018-06-04  5:34     ` Lee Jones
  0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2018-06-01  7:50 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-kernel, Mika Westerberg

On Fri, 2018-05-18 at 14:51 +0100, Lee Jones wrote:
> On Tue, 24 Apr 2018, Andy Shevchenko wrote:
> 
> > According to documentation REMAP register has to be programmed in
> > either DMA or PIO mode of the slice.
> > 
> > Move the DMA capability check below to let REMAP register be
> > programmed
> > in PIO mode.
> > 
> > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > devices")
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/mfd/intel-lpss.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied and tagged for -stable # 4.3+

Thanks!

Though can not see it in Linus' tree still.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode
  2018-06-01  7:50   ` Andy Shevchenko
@ 2018-06-04  5:34     ` Lee Jones
  0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2018-06-04  5:34 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-kernel, Mika Westerberg

On Fri, 01 Jun 2018, Andy Shevchenko wrote:

> On Fri, 2018-05-18 at 14:51 +0100, Lee Jones wrote:
> > On Tue, 24 Apr 2018, Andy Shevchenko wrote:
> > 
> > > According to documentation REMAP register has to be programmed in
> > > either DMA or PIO mode of the slice.
> > > 
> > > Move the DMA capability check below to let REMAP register be
> > > programmed
> > > in PIO mode.
> > > 
> > > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS
> > > devices")
> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  drivers/mfd/intel-lpss.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Applied and tagged for -stable # 4.3+
> 
> Thanks!
> 
> Though can not see it in Linus' tree still.

Why would it be in Linus' tree?

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-06-04  5:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 15:00 [PATCH v1] mfd: intel-lpss: Program REMAP register in PIO mode Andy Shevchenko
2018-04-25 10:25 ` Mika Westerberg
2018-05-18 10:17   ` Andy Shevchenko
2018-05-18 13:47     ` Lee Jones
2018-05-18 13:51 ` Lee Jones
2018-06-01  7:50   ` Andy Shevchenko
2018-06-04  5:34     ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).