From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C726C6778A for ; Thu, 5 Jul 2018 18:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2768D205F4 for ; Thu, 5 Jul 2018 18:53:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2768D205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbeGESxd (ORCPT ); Thu, 5 Jul 2018 14:53:33 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47212 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753987AbeGESwV (ORCPT ); Thu, 5 Jul 2018 14:52:21 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w65InQ9g054306 for ; Thu, 5 Jul 2018 14:52:21 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k1p1x779k-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 05 Jul 2018 14:52:21 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Jul 2018 14:52:19 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 5 Jul 2018 14:52:16 -0400 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w65IqFfc2032156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 5 Jul 2018 18:52:15 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 32132124052; Thu, 5 Jul 2018 15:53:36 -0400 (EDT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1C0AE12405A; Thu, 5 Jul 2018 15:53:35 -0400 (EDT) Received: from [9.41.102.69] (unknown [9.41.102.69]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 5 Jul 2018 15:53:35 -0400 (EDT) Subject: Re: [PATCH v10 5/7] i2c: fsi: Add transfer implementation To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, benh@kernel.crashing.org, joel@jms.id.au, mark.rutland@arm.com, gregkh@linuxfoundation.org, rdunlap@infradead.org, andy.shevchenko@gmail.com, peda@axentia.se References: <1528918579-27602-1-git-send-email-eajames@linux.vnet.ibm.com> <1528918579-27602-6-git-send-email-eajames@linux.vnet.ibm.com> <20180626023823.i3fmdegn2sric5kx@ninjato> <6713efb9-c4c3-f648-a1e9-7918110091e4@linux.vnet.ibm.com> <20180702182434.5wxxszpgpf6wergl@ninjato> From: Eddie James Date: Thu, 5 Jul 2018 13:52:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180702182434.5wxxszpgpf6wergl@ninjato> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18070518-0052-0000-0000-000003099001 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009314; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01057023; UDB=6.00542281; IPR=6.00834943; MB=3.00022012; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-05 18:52:19 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18070518-0053-0000-0000-00005D419893 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-05_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807050209 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2018 01:24 PM, Wolfram Sang wrote: >>>> + if (msg->flags & I2C_M_RD) >>>> + cmd |= I2C_CMD_READ; >>> Since you support MANGLING, I'd think you can easily support >>> I2C_M_REV_DIR_ADDR here, too? >> Hm, I don't really understand the purpose of that flag. From the docs: >> >> This toggles the Rd/Wr flag. That is, if you want to do a write, but >>     need to emit an Rd instead of a Wr, or vice versa, you set this >>     flag. For example: >> S Addr Rd [A] Data [A] Data [A] ... [A] Data [A] P >> >> I don't think our hardware supports this type of operation. > I'd think something like this should do: > > if (msg->flags & I2C_M_REV_DIR_ADDR) > cmd ^= I2C_CMD_READ; I meant that the hardware cannot interpret this, it would be a meaningless command unfortunately. >