LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Mark Brown <broonie@kernel.org>,
	Eduardo Valentin <edubezval@gmail.com>,
	Elaine Zhang <zhangqing@rock-chips.com>
Cc: tomeu.vizoso@collabora.com, guillaume.tucker@collabora.com,
	mgalka@collabora.com, matthew.hart@linaro.org,
	khilman@baylibre.com, Daniel Lezcano <daniel.lezcano@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Zhang Rui <rui.zhang@intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: mainline/master boot bisection: v5.2-rc1-165-g54dee406374c on rk3288-veyron-jaq
Date: Thu, 23 May 2019 15:18:56 +0200	[thread overview]
Message-ID: <ac2f06ac-2bf5-7af6-06c3-37b865c43738@collabora.com> (raw)
In-Reply-To: <20190523131207.GC17245@sirena.org.uk>

Hi Mark,

On 23/5/19 15:12, Mark Brown wrote:
> On Wed, May 22, 2019 at 07:23:09PM -0700, kernelci.org bot wrote:
> 
>>   Details:    https://kernelci.org/boot/id/5ce5984c59b514e6a47a364c
>>   Plain log:  https://storage.kernelci.org//mainline/master/v5.2-rc1-165-g54dee406374c/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.txt
>>   HTML log:   https://storage.kernelci.org//mainline/master/v5.2-rc1-165-g54dee406374c/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y/gcc-8/lab-collabora/boot-rk3288-veyron-jaq.html
>>   Result:     28694e009e51 thermal: rockchip: fix up the tsadc pinctrl setting error
> 
> It looks like this issue has persisted for a while without any kind of
> fix happening - given that the bisection has identified this commit as
> causing the regression and confirmed that reverting it fixes shouldn't
> we just revert?  My guess would be that there's some error with the
> pinctrl settings in the DT for the board.
> 

After some discussion Heiko sent a patch that reverts the offending commit one
day ago [1] and it's waiting for maintainer to pick-up the patch.

The reason why we think is best reverting that fix it is explained here [2]

[1] https://lkml.org/lkml/2019/5/22/467
[2] https://lkml.org/lkml/2019/4/30/270

Thanks,
 Enric

  reply	other threads:[~2019-05-23 13:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  2:23 mainline/master boot bisection: v5.2-rc1-165-g54dee406374c on rk3288-veyron-jaq kernelci.org bot
2019-05-23 13:12 ` Mark Brown
2019-05-23 13:18   ` Enric Balletbo i Serra [this message]
2019-05-23 14:02     ` Zhang, Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac2f06ac-2bf5-7af6-06c3-37b865c43738@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=broonie@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=guillaume.tucker@collabora.com \
    --cc=heiko@sntech.de \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=matthew.hart@linaro.org \
    --cc=mgalka@collabora.com \
    --cc=rui.zhang@intel.com \
    --cc=tomeu.vizoso@collabora.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).