LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "Rusty Russell" <rusty@rustcorp.com.au>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, "Greg KH" <greg@kroah.com>
Subject: Re: virtio: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Thu, 6 Nov 2008 07:28:56 +0100	[thread overview]
Message-ID: <ac3eb2510811052228o305b432cp2df9d311f103fc92@mail.gmail.com> (raw)
In-Reply-To: <200811061445.12050.rusty@rustcorp.com.au>

On Thu, Nov 6, 2008 at 04:45, Rusty Russell <rusty@rustcorp.com.au> wrote:
> On Friday 31 October 2008 06:10:22 Kay Sievers wrote:
>> This patch is part of a larger patch series which will remove
>> the "char bus_id[20]" name string from struct device. The device
>> name is managed in the kobject anyway, and without any size
>> limitation, and just needlessly copied into "struct device".
>
> OK, I've applied this patch.

Thanks!

> I'm curious how you're going to handle out-of-memory conditions?

If the name can't be set, the following call to device_register() will
fail, and should be handled by the caller. Just like today when we
allocate the kobject name in device_register(). After the core has
switched over, the name allocation will only happen a few lines
earlier, it should not behave different otherwise. Is that what you
mean?

Thanks,
Kay

  reply	other threads:[~2008-11-06  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 19:10 Kay Sievers
2008-11-06  3:45 ` Rusty Russell
2008-11-06  6:28   ` Kay Sievers [this message]
2008-11-06 11:18     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac3eb2510811052228o305b432cp2df9d311f103fc92@mail.gmail.com \
    --to=kay.sievers@vrfy.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --subject='Re: virtio: struct device - replace bus_id with dev_name(), dev_set_name()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).