LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: Jim Mattson <jmattson@google.com>,
	Sean Christopherson <sean.j.christopherson@intel.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] KVM: VMX: rename 'kvm_area' to 'vmxon_region'
Date: Fri, 6 Mar 2020 14:05:30 -0800	[thread overview]
Message-ID: <ad7785c5-34e0-a4e9-689c-f4626dc37314@oracle.com> (raw)
In-Reply-To: <20200306130215.150686-2-vkuznets@redhat.com>


On 3/6/20 5:02 AM, Vitaly Kuznetsov wrote:
> The name 'kvm_area' is misleading (as we have way too many areas which are
> KVM related), what alloc_kvm_area()/free_kvm_area() functions really do is
> allocate/free VMXON region for all CPUs. Rename accordingly.
>
> No functional change intended.
>
> Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>   arch/x86/kvm/vmx/vmx.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 40b1e6138cd5..dab19e4e5f2b 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -2635,7 +2635,7 @@ int alloc_loaded_vmcs(struct loaded_vmcs *loaded_vmcs)
>   	return -ENOMEM;
>   }
>   
> -static void free_kvm_area(void)
> +static void free_vmxon_regions(void)
>   {
>   	int cpu;
>   
> @@ -2645,7 +2645,7 @@ static void free_kvm_area(void)
>   	}
>   }
>   
> -static __init int alloc_kvm_area(void)
> +static __init int alloc_vmxon_regions(void)
>   {
>   	int cpu;
>   
> @@ -2654,7 +2654,7 @@ static __init int alloc_kvm_area(void)
>   
>   		vmcs = alloc_vmcs_cpu(false, cpu, GFP_KERNEL);
>   		if (!vmcs) {
> -			free_kvm_area();
> +			free_vmxon_regions();
>   			return -ENOMEM;
>   		}
>   
> @@ -7815,7 +7815,7 @@ static __init int hardware_setup(void)
>   			return r;
>   	}
>   
> -	r = alloc_kvm_area();
> +	r = alloc_vmxon_regions();
>   	if (r)
>   		nested_vmx_hardware_unsetup();
>   	return r;
> @@ -7826,7 +7826,7 @@ static __exit void hardware_unsetup(void)
>   	if (nested)
>   		nested_vmx_hardware_unsetup();
>   
> -	free_kvm_area();
> +	free_vmxon_regions();
>   }
>   
>   static bool vmx_check_apicv_inhibit_reasons(ulong bit)
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>

  reply	other threads:[~2020-03-06 22:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 13:02 [PATCH v3 0/2] KVM: VMX: cleanup VMXON region allocation Vitaly Kuznetsov
2020-03-06 13:02 ` [PATCH v3 1/2] KVM: VMX: rename 'kvm_area' to 'vmxon_region' Vitaly Kuznetsov
2020-03-06 22:05   ` Krish Sadhukhan [this message]
2020-03-06 13:02 ` [PATCH v3 2/2] KVM: VMX: untangle VMXON revision_id setting when using eVMCS Vitaly Kuznetsov
2020-03-06 22:20   ` Krish Sadhukhan
2020-03-06 23:07     ` Sean Christopherson
2020-03-06 23:57       ` Krish Sadhukhan
2020-03-07  0:28         ` Sean Christopherson
2020-03-07  1:34           ` Krish Sadhukhan
2020-03-09  9:31           ` Vitaly Kuznetsov
2020-03-18 17:17             ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad7785c5-34e0-a4e9-689c-f4626dc37314@oracle.com \
    --to=krish.sadhukhan@oracle.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --subject='Re: [PATCH v3 1/2] KVM: VMX: rename '\''kvm_area'\'' to '\''vmxon_region'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).