LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] IB/ehca: Prevent sending UD packets to QP0
@ 2008-01-24 16:59 Joachim Fenkes
  2008-01-31  4:06 ` Roland Dreier
  0 siblings, 1 reply; 2+ messages in thread
From: Joachim Fenkes @ 2008-01-24 16:59 UTC (permalink / raw)
  To: LinuxPPC-Dev, LKML, OF-General, Roland Dreier, OF-EWG
  Cc: Hoang-Nam Nguyen, Christoph Raisch, Stefan Roscher

IB spec doesn't allow packets to QP0 sent on any other VL than VL15.
Hardware doesn't filter those packets on the send side, so we need to do
this in the driver and firmware.

As eHCA doesn't support QP0, we can just filter out all traffic going to
QP0, regardless of SL or VL.

Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
---
 drivers/infiniband/hw/ehca/ehca_reqs.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_reqs.c b/drivers/infiniband/hw/ehca/ehca_reqs.c
index 3aacc8c..2ce8cff 100644
--- a/drivers/infiniband/hw/ehca/ehca_reqs.c
+++ b/drivers/infiniband/hw/ehca/ehca_reqs.c
@@ -209,6 +209,10 @@ static inline int ehca_write_swqe(struct ehca_qp *qp,
 			ehca_gen_err("wr.ud.ah is NULL. qp=%p", qp);
 			return -EINVAL;
 		}
+		if (unlikely(send_wr->wr.ud.remote_qpn == 0)) {
+			ehca_gen_err("dest QP# is 0. qp=%x", qp->real_qp_num);
+			return -EINVAL;
+		}
 		my_av = container_of(send_wr->wr.ud.ah, struct ehca_av, ib_ah);
 		wqe_p->u.ud_av.ud_av = my_av->av;
 
-- 
1.5.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] IB/ehca: Prevent sending UD packets to QP0
  2008-01-24 16:59 [PATCH] IB/ehca: Prevent sending UD packets to QP0 Joachim Fenkes
@ 2008-01-31  4:06 ` Roland Dreier
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2008-01-31  4:06 UTC (permalink / raw)
  To: Joachim Fenkes
  Cc: LinuxPPC-Dev, LKML, OF-General, Roland Dreier, OF-EWG,
	Hoang-Nam Nguyen, Christoph Raisch, Stefan Roscher

thanks, applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-31  4:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-24 16:59 [PATCH] IB/ehca: Prevent sending UD packets to QP0 Joachim Fenkes
2008-01-31  4:06 ` Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).