LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com> To: Davide Libenzi <davidel@xmailserver.org> Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Avi Kivity <avi@qumranet.com>, kvm-devel@lists.sourceforge.net, Andrew Morton <akpm@linux-foundation.org>, Al Viro <viro@ftp.linux.org.uk> Subject: Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Date: Wed, 27 Feb 2008 12:14:24 -0800 [thread overview] Message-ID: <adabq62yx5r.fsf@cisco.com> (raw) In-Reply-To: <Pine.LNX.4.64.0802271138170.377@alien.or.mcafeemobile.com> (Davide Libenzi's message of "Wed, 27 Feb 2008 11:41:24 -0800 (PST)") > > The anonymous inodes interface anon_inode_getfd() calls fd_install() > > for the newly created fd, which does not work for some use cases where > > the caller must do futher initialization before exposing the file to > > userspace. This is also probably not the safest interface, since the > > caller must be sure that it is OK if userspace closes the fd before > > anon_inode_getfd() even returns. > > I believe Al changed the interface to not give out inode* and file*, *and* > call fd_install() inside it. I'd slightly prefer Al version, although I > don't see any major problems in this one too. Any pointer to that patch? A web search for "viro" and "anon_inode_getfd" doesn't turn up anything likely looking. - R.
next prev parent reply other threads:[~2008-02-27 20:14 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20080225191043.GA32342@lst.de> 2008-02-27 19:16 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Roland Dreier 2008-02-27 19:18 ` [PATCH 2/2] IB/uverbs: Use anonymous inodes instead of private filesystem Roland Dreier 2008-02-27 19:20 ` [PATCH/RFC 1/2] anon-inodes: Remove fd_install() from anon_inode_getfd() Avi Kivity 2008-02-27 19:41 ` Davide Libenzi 2008-02-27 20:14 ` Roland Dreier [this message] 2008-02-27 20:30 ` Davide Libenzi 2008-02-27 21:05 ` Roland Dreier 2008-02-27 23:42 ` Roland Dreier 2008-02-28 7:52 ` Avi Kivity 2008-02-28 20:04 ` Davide Libenzi 2008-02-28 20:24 ` Roland Dreier 2008-02-28 20:52 ` Davide Libenzi 2008-03-05 9:32 ` [kvm-devel] " Avi Kivity 2008-03-06 15:14 ` Christoph Hellwig 2008-03-09 2:45 ` Roland Dreier 2008-03-17 10:40 ` Christoph Hellwig 2008-03-17 10:48 ` Avi Kivity 2008-03-09 2:46 ` Roland Dreier 2008-03-06 15:14 ` Al Viro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=adabq62yx5r.fsf@cisco.com \ --to=rdreier@cisco.com \ --cc=akpm@linux-foundation.org \ --cc=avi@qumranet.com \ --cc=davidel@xmailserver.org \ --cc=hch@lst.de \ --cc=kvm-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=viro@ftp.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).