LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6.25] RDMA/IWCM: don't access the cm_id after dereferencing it.
@ 2008-03-04 22:44 Steve Wise
  2008-03-11  4:23 ` Roland Dreier
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Wise @ 2008-03-04 22:44 UTC (permalink / raw)
  To: rdreier, sean.hefty; +Cc: linux-kernel, netdev, general


RDMA/IWCM: don't access the cm_id after dereferencing it.

cm_work_handler() can access cm_id_priv after it was potentially freed
by iwch_deref_id().  The fix is to note whether IWCM_F_CALLBACK_DESTROY
is set before dereferencing.  Then if it was set, free the cm_id on
this thread.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---

 drivers/infiniband/core/iwcm.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c
index 223b1aa..81c9195 100644
--- a/drivers/infiniband/core/iwcm.c
+++ b/drivers/infiniband/core/iwcm.c
@@ -839,6 +839,7 @@ static void cm_work_handler(struct work_struct *_work)
 	unsigned long flags;
 	int empty;
 	int ret = 0;
+	int destroy_id;
 
 	spin_lock_irqsave(&cm_id_priv->lock, flags);
 	empty = list_empty(&cm_id_priv->work_list);
@@ -857,9 +858,9 @@ static void cm_work_handler(struct work_struct *_work)
 			destroy_cm_id(&cm_id_priv->id);
 		}
 		BUG_ON(atomic_read(&cm_id_priv->refcount)==0);
+		destroy_id = test_bit(IWCM_F_CALLBACK_DESTROY, &cm_id_priv->flags);
 		if (iwcm_deref_id(cm_id_priv)) {
-			if (test_bit(IWCM_F_CALLBACK_DESTROY,
-				     &cm_id_priv->flags)) {
+			if (destroy_id) {
 				BUG_ON(!list_empty(&cm_id_priv->work_list));
 				free_cm_id(cm_id_priv);
 			}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6.25] RDMA/IWCM: don't access the cm_id after dereferencing it.
  2008-03-04 22:44 [PATCH 2.6.25] RDMA/IWCM: don't access the cm_id after dereferencing it Steve Wise
@ 2008-03-11  4:23 ` Roland Dreier
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2008-03-11  4:23 UTC (permalink / raw)
  To: Steve Wise; +Cc: sean.hefty, linux-kernel, netdev, general

thanks, applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-11  4:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-04 22:44 [PATCH 2.6.25] RDMA/IWCM: don't access the cm_id after dereferencing it Steve Wise
2008-03-11  4:23 ` Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).