LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6.25] RDMA/cxgb3: Fail loopback connections.
@ 2008-02-12 22:09 Steve Wise
  2008-02-13  0:26 ` [ofa-general] " Roland Dreier
  0 siblings, 1 reply; 9+ messages in thread
From: Steve Wise @ 2008-02-12 22:09 UTC (permalink / raw)
  To: rdreier; +Cc: netdev, linux-kernel, general


RDMA/cxgb3: Fail loopback connections.

The cxgb3 HW and driver don't support loopback RDMA connections.  So fail
any connection attempt where the destination address is local.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---

 drivers/infiniband/hw/cxgb3/iwch_cm.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index e9a08fa..5d82723 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1784,6 +1784,17 @@ err:
 	return err;
 }
 
+static void is_loopback_dst(struct iw_cm_id *cm_id)
+{
+	struct net_device *dev;
+	
+	dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr);
+	if (!dev)
+		return 0;
+	dev_put(dev);
+	return 1;
+}
+
 int iwch_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
 {
 	int err = 0;
@@ -1791,6 +1802,11 @@ int iwch_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
 	struct iwch_ep *ep;
 	struct rtable *rt;
 
+	if (is_loopback_dst(cm_id)) {
+		err = -ENOSYS;
+		goto out;
+	}
+
 	ep = alloc_ep(sizeof(*ep), GFP_KERNEL);
 	if (!ep) {
 		printk(KERN_ERR MOD "%s - cannot alloc ep.\n", __FUNCTION__);

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2008-02-13 16:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-12 22:09 [PATCH 2.6.25] RDMA/cxgb3: Fail loopback connections Steve Wise
2008-02-13  0:26 ` [ofa-general] " Roland Dreier
2008-02-13  1:41   ` Steve Wise
2008-02-13  9:18   ` [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections Diego Guella
2008-02-13 15:46     ` Roland Dreier
2008-02-13 15:47       ` Steve Wise
2008-02-13 15:49       ` Roland Dreier
2008-02-13 15:51         ` Steve Wise
2008-02-13 16:03           ` Steve Wise

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).