LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: jeff@garzik.org
Cc: "Phillip O'Donnell" <phillip.odonnell@gmail.com>,
	"Oskar Liljeblad" <oskar@osk.mine.nu>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] libata: Avoid overflow in ata_tf_read_block() when tf->hba_lbal > 127
Date: Tue, 04 Nov 2008 10:34:48 -0800	[thread overview]
Message-ID: <adatzantk53.fsf_-_@cisco.com> (raw)
In-Reply-To: <7a9b5c320810281904x6b8b3226uaba502146be854a7@mail.gmail.com> (Phillip O'Donnell's message of "Wed, 29 Oct 2008 15:04:17 +1300")

Phillip O'Donnell <phillip.odonnell@gmail.com> pointed out that the same
sign extension bug that was fixed in commit ba14a9c2 ("libata: Avoid
overflow in ata_tf_to_lba48() when tf->hba_lbal > 127") also appears to
exist in ata_tf_read_block().  Fix this by adding a cast to u64.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
I don't have any way to test this -- I guess you would have to get an
error on a block above 2G (ie data above 1TB)?  But it looks "obviously
correct" enough to add to -next I guess.

 drivers/ata/libata-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 622350d..a6ad862 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -612,7 +612,7 @@ u64 ata_tf_read_block(struct ata_taskfile *tf, struct ata_device *dev)
 		if (tf->flags & ATA_TFLAG_LBA48) {
 			block |= (u64)tf->hob_lbah << 40;
 			block |= (u64)tf->hob_lbam << 32;
-			block |= tf->hob_lbal << 24;
+			block |= (u64)tf->hob_lbal << 24;
 		} else
 			block |= (tf->device & 0xf) << 24;
 

  reply	other threads:[~2008-11-04 18:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28 17:01 sata errors with Seagate 1.5TB on AMD 780G/SB700 motherboard Oskar Liljeblad
2008-10-28 17:59 ` David Rees
2008-10-28 23:25 ` Phillip O'Donnell
2008-10-28 23:52   ` [PATCH] libata: Avoid overflow in ata_tf_to_lba48() when tf->hba_lbal > 127 Roland Dreier
2008-10-29  2:04     ` Phillip O'Donnell
2008-11-04 18:34       ` Roland Dreier [this message]
     [not found]         ` <7a9b5c320811041441q78920938q58ed7ab3cbe97253@mail.gmail.com>
2008-11-04 22:44           ` [PATCH] libata: Avoid overflow in ata_tf_read_block() " Phillip O'Donnell
2008-11-11  8:02         ` Jeff Garzik
2008-10-29 13:28     ` [PATCH] libata: Avoid overflow in ata_tf_to_lba48() " Phillip O'Donnell
2008-10-31  5:45     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adatzantk53.fsf_-_@cisco.com \
    --to=rdreier@cisco.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oskar@osk.mine.nu \
    --cc=phillip.odonnell@gmail.com \
    --subject='Re: [PATCH] libata: Avoid overflow in ata_tf_read_block() when tf->hba_lbal > 127' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).