LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Jeff Davis <linux@j-davis.com>,
	balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Andrea Arcangeli <andrea@qumranet.com>
Subject: Re: [PATCH] badness() dramatically overcounts memory
Date: Tue, 5 Feb 2008 18:05:46 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.1.00.0802051802460.18339@chino.kir.corp.google.com> (raw)
In-Reply-To: <20080206105041.2717.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Wed, 6 Feb 2008, KOSAKI Motohiro wrote:

> > Andrea Arcangeli has patches pending which change this to the RSS.  
> > Specifically:
> > 
> > 	http://marc.info/?l=linux-mm&m=119977937126925
> 
> I agreed with you that RSS is better :)
> 
> 
> 
> but..
> on many node numa, per zone rss is more better..
> 

It depends on how your applications are taking advantage of NUMA 
optimizations.  If they're constrained by mempolicies to a subset of nodes 
then the badness scoring isn't even used: the task that triggered the OOM 
condition is the one that is automatically killed.

At this point, I think you're going to need to present an actual case 
study where Andrea's patch isn't sufficient for selecting the appropriate 
task on large NUMA machines.

		David

  reply	other threads:[~2008-02-06  2:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1202182480.24634.22.camel@dogma.ljc.laika.com>
2008-02-05  4:13 ` Balbir Singh
2008-02-05 23:02   ` Jeff Davis
2008-02-05 23:09     ` David Rientjes
2008-02-06  1:54       ` KOSAKI Motohiro
2008-02-06  2:05         ` David Rientjes [this message]
2008-02-06  4:00         ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0802051802460.18339@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=andrea@qumranet.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@j-davis.com \
    --subject='Re: [PATCH] badness() dramatically overcounts memory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).