LKML Archive on
help / color / mirror / Atom feed
From: David Rientjes <>
To: Lee Schermerhorn <>
Cc: Andrew Morton <>,
	Paul Jackson <>, Christoph Lameter <>,
	Andi Kleen <>,, linux-mm <>,
	Eric Whitney <>
Subject: Re: Regression:  Re: [patch -mm 2/4] mempolicy: create mempolicy_operations structure
Date: Fri, 7 Mar 2008 13:48:59 -0800 (PST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1204922646.5340.73.camel@localhost>

On Fri, 7 Mar 2008, Lee Schermerhorn wrote:

> It also appears that the patch series listed above required a non-empty
> nodemask with MPOL_DEFAULT.  However, I didn't test that.  With this
> patch, MPOL_DEFAULT effectively ignores the nodemask--empty or not.
> This is a change in behavior that I have argued against, but the
> regression tests don't test this, so I'm not going to attempt to address
> it with this patch.

Excuse me, but there was significant discussion about this on LKML and I 
eventually did force MPOL_DEFAULT to require a non-empty nodemask 
specifically because of your demand that it should.  It didn't originally 
require this in my patchset, and now you're removing the exact same 
requirement that you demanded.

You said on February 13:

	1) we've discussed the issue of returning EINVAL for non-empty
	nodemasks with MPOL_DEFAULT.  By removing this restriction, we run
	the risk of breaking applications if we should ever want to define
	a semantic to non-empty node mask for MPOL_DEFAULT.

If you want to remove this requirement now (please get agreement from 
Paul) and are sure of your position, you'll at least need an update to 

  reply	other threads:[~2008-03-07 21:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 20:05 [patch -mm 1/4] mempolicy: move rebind functions David Rientjes
2008-03-06 20:05 ` [patch -mm 2/4] mempolicy: create mempolicy_operations structure David Rientjes
2008-03-06 20:05   ` [patch -mm 3/4] mempolicy: small header file cleanup David Rientjes
2008-03-06 20:05     ` [patch -mm 4/4] mempolicy: remove includes for duplicate headers David Rientjes
2008-03-06 20:19       ` Paul Jackson
2008-03-06 20:51         ` David Rientjes
2008-03-06 21:01           ` Paul Jackson
2008-03-07  8:45             ` Andrew Morton
2008-03-07 20:44   ` Regression: Re: [patch -mm 2/4] mempolicy: create mempolicy_operations structure Lee Schermerhorn
2008-03-07 21:48     ` David Rientjes [this message]
2008-03-07 21:57       ` Paul Jackson
2008-03-08 18:49       ` Lee Schermerhorn
2008-03-08 22:09         ` David Rientjes
2008-03-10 14:58           ` Lee Schermerhorn
2008-03-12 19:33       ` [PATCH] Mempolicy: fix parsing of tmpfs mpol mount option Lee Schermerhorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: Regression:  Re: [patch -mm 2/4] mempolicy: create mempolicy_operations structure' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).