LKML Archive on
help / color / mirror / Atom feed
From: Steven Rostedt <>
To: Ingo Molnar <>
Cc: Rakib Mullick <>,,
	Andrew Morton <>
Subject: Re: [PATCH] ftrace: use a real variable for ftrace_nop in x86
Date: Fri, 24 Oct 2008 09:17:37 -0400 (EDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 24 Oct 2008, Steven Rostedt wrote:

> The dynamic ftrace determines which nop is safe to use at start up.
> When it finds a safe nop for patching, it sets a pointer called ftrace_nop
> to point to the code. All call sites are then patched to this nop.
> Later, when tracing is turned on, this ftrace_nop variable is again used
> to compare the location to make sure it is a nop before we update it to
> a mcount call. If this fails just once, a warning is outputed and ftrace
> is disabled.
> Rakib Mullick noted that the code that sets up the nop is a .init section
> where as the nop itself is in the .text section. This is needed because
> the nop is used later on after boot up. The problem is that the test of the
> nop jumps back to the setup code and causes a "section mismatch" warning.
> Rabik first recommended to convert the nop to .init.text, but as stated
> above, this would fail since that text is used later.
> The real solution is to extend Rabik's patch, and to make the ftrace_nop
> into an array, and just save the code from the assembly to this array.

Rereading what I sent, I see I misspelled Rakib's name twice.

Ingo, could you fix the changelog here before commiting it.


-- Steve

  reply	other threads:[~2008-10-24 13:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  5:50 [PATCH -mm] ftrace : Fix section mismatch warning Rakib Mullick
2008-10-20 16:27 ` Ingo Molnar
2008-10-22  7:03   ` Ingo Molnar
2008-10-24 11:09     ` Rakib Mullick
2008-10-24 11:50       ` Ingo Molnar
2008-10-24 12:19         ` Steven Rostedt
2008-10-24 12:22           ` Steven Rostedt
2008-10-24 13:12         ` [PATCH] ftrace: use a real variable for ftrace_nop in x86 Steven Rostedt
2008-10-24 13:17           ` Steven Rostedt [this message]
2008-10-27 15:52             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] ftrace: use a real variable for ftrace_nop in x86' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).