LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch] vmemmap: warn about page_structs with remote distance
@ 2008-10-28 16:05 David Rientjes
  2008-10-30 16:02 ` Christoph Lameter
  0 siblings, 1 reply; 2+ messages in thread
From: David Rientjes @ 2008-10-28 16:05 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Christoph Lameter, linux-kernel

It's insufficient to simply compare node ids when warning about offnode
page_structs since it's possible to still have local affinity.

Cc: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/sparse-vmemmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
--- a/mm/sparse-vmemmap.c
+++ b/mm/sparse-vmemmap.c
@@ -64,7 +64,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node,
 	unsigned long pfn = pte_pfn(*pte);
 	int actual_node = early_pfn_to_nid(pfn);
 
-	if (actual_node != node)
+	if (node_distance(actual_node, node) > LOCAL_DISTANCE)
 		printk(KERN_WARNING "[%lx-%lx] potential offnode "
 			"page_structs\n", start, end - 1);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] vmemmap: warn about page_structs with remote distance
  2008-10-28 16:05 [patch] vmemmap: warn about page_structs with remote distance David Rientjes
@ 2008-10-30 16:02 ` Christoph Lameter
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2008-10-30 16:02 UTC (permalink / raw)
  To: David Rientjes; +Cc: Andrew Morton, linux-kernel

On Tue, 28 Oct 2008, David Rientjes wrote:

> It's insufficient to simply compare node ids when warning about offnode
> page_structs since it's possible to still have local affinity.

Well that means that we distinguish nodes on the same motherboard (f.e. 
AMD memory architecture) from nodes that are on truly remote nodes.

Guess the delays on a single motherboard do not matter much?

Acked-by: Christoph Lameter <cl@linux-foundation.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-30 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-28 16:05 [patch] vmemmap: warn about page_structs with remote distance David Rientjes
2008-10-30 16:02 ` Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).