LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>, Paul Menage <menage@google.com>,
Derek Fults <dfults@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 3/7] mm: make page writeback obey cpuset constraints
Date: Tue, 28 Oct 2008 12:18:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0810281216570.30390@chino.kir.corp.google.com> (raw)
In-Reply-To: <1225215134.15763.27.camel@lappy.programming.kicks-ass.net>
On Tue, 28 Oct 2008, Peter Zijlstra wrote:
> > + is_subset = cpuset_populate_dirty_limits(dl, &dirtyable_memory,
> > + &nr_mapped, nodes);
> > + if (!is_subset) {
> > + dl->nr_dirty = global_page_state(NR_FILE_DIRTY);
> > + dl->nr_unstable = global_page_state(NR_UNSTABLE_NFS);
> > + dl->nr_writeback = global_page_state(NR_WRITEBACK);
> > + dirtyable_memory = determine_dirtyable_memory();
> > + nr_mapped = global_page_state(NR_FILE_MAPPED) +
> > + global_page_state(NR_ANON_PAGES);
> > + } else
> > + dirtyable_memory -= highmem_dirtyable_memory(nodes,
> > + dirtyable_memory);
>
> Why not fold that all into cpuset_populate_dirty_limits() ?
>
cpuset_populate_dirty_limits() is a no-op on !CONFIG_CPUSETS kernels.
next prev parent reply other threads:[~2008-10-28 19:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 16:08 [patch 1/7] cpusets: add dirty map to struct address_space David Rientjes
2008-10-28 16:08 ` [patch 2/7] pdflush: allow the passing of a nodemask parameter David Rientjes
2008-10-28 16:08 ` [patch 3/7] mm: make page writeback obey cpuset constraints David Rientjes
2008-10-28 17:31 ` Peter Zijlstra
2008-10-28 19:16 ` David Rientjes
2008-10-28 17:32 ` Peter Zijlstra
2008-10-28 19:18 ` David Rientjes [this message]
2008-10-30 8:42 ` Peter Zijlstra
2008-10-30 9:10 ` David Rientjes
2008-10-30 9:34 ` Peter Zijlstra
2008-10-28 16:08 ` [patch 4/7] mm: cpuset aware reclaim writeout David Rientjes
2008-10-28 16:08 ` [patch 5/7] mm: throttle writeout with cpuset awareness David Rientjes
2008-10-28 16:08 ` [patch 6/7] cpusets: per cpuset dirty ratios David Rientjes
2008-10-30 6:59 ` Paul Menage
2008-10-30 8:48 ` David Rientjes
2008-10-30 15:28 ` Christoph Lameter
2008-10-30 8:44 ` Peter Zijlstra
2008-10-30 9:03 ` David Rientjes
2008-10-30 9:34 ` Peter Zijlstra
2008-10-30 10:02 ` David Rientjes
2008-10-28 16:08 ` [patch 7/7] cpusets: update documentation for writeback throttling David Rientjes
2008-10-30 16:06 ` Christoph Lameter
2008-10-28 17:37 ` [patch 1/7] cpusets: add dirty map to struct address_space Peter Zijlstra
2008-10-28 20:48 ` David Rientjes
2008-10-29 1:13 ` David Rientjes
2008-10-29 2:24 ` David Rientjes
2008-10-30 8:38 ` Peter Zijlstra
2008-10-28 17:46 ` Peter Zijlstra
2008-10-28 19:19 ` David Rientjes
2008-10-30 19:23 [patch 0/7] cpuset writeback throttling David Rientjes
2008-10-30 19:23 ` [patch 3/7] mm: make page writeback obey cpuset constraints David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0810281216570.30390@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=dfults@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--subject='Re: [patch 3/7] mm: make page writeback obey cpuset constraints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).