LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Make ftrace able to trace function return
Date: Thu, 30 Oct 2008 22:43:42 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.1.10.0810302241420.21031@gandalf.stny.rr.com> (raw)
In-Reply-To: <c62985530810301705h356decf8oea0db02def2ab3c1@mail.gmail.com>


On Fri, 31 Oct 2008, Fr?d?ric Weisbecker wrote:

> 2008/10/30 Steven Rostedt <rostedt@goodmis.org>:
> > What about storing the return addresses on the bottom of the stack?
> > That is, start at task->stack + sizeof(thread_info), and stack up on that.
> > Be careful, there might already be users of that area. This will also need
> > to be arch dependent.
> 
> But how could I assume there is enough space behind this address to store a long
> stack of functions calls for a same thread?
> And if an interrupt is raised, would a reference to "current task" be
> really consistant?
> 
> I don't know much about the bottom stack of the tasks, I'm not sure
> about how much
> space I can use inside... I should study this field. Who could be the
> potential users of this area?
> 

Because it is the real stack ;-)

Before adding, test to see if the real stack pointer is getting close. If 
it is, then there's probably more issues.  You can run the stack_tracer to 
see how much stack is available too.

-- Steve


  reply	other threads:[~2008-10-31  2:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 19:20 Frederic Weisbecker
2008-10-30 18:20 ` Ingo Molnar
2008-10-30 18:30   ` Frédéric Weisbecker
2008-10-30 18:37     ` Ingo Molnar
2008-10-30 19:17       ` Steven Rostedt
2008-10-30 19:26         ` Ingo Molnar
2008-11-03 11:16           ` Ananth N Mavinakayanahalli
2008-11-03 13:32             ` Frédéric Weisbecker
2008-10-31  1:35       ` Frédéric Weisbecker
2008-10-30 20:30 ` Steven Rostedt
2008-10-31  0:05   ` Frédéric Weisbecker
2008-10-31  2:43     ` Steven Rostedt [this message]
2008-10-31 20:18       ` Frederic Weisbecker
2008-11-03 10:06         ` Ingo Molnar
2008-11-03 13:11           ` Frédéric Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0810302241420.21031@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [RFC][PATCH] Make ftrace able to trace function return' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).