LKML Archive on
help / color / mirror / Atom feed
From: Steven Rostedt <>
To: Ingo Molnar <>
Cc: Heiko Carstens <>,
	Peter Zijlstra <>,
Subject: Re: bug: ftrace & lockdep badness
Date: Wed, 5 Nov 2008 11:47:52 -0500 (EST)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 5 Nov 2008, Ingo Molnar wrote:

> * Steven Rostedt <> wrote:
> > This is the type of problems we deal with when we have the tracer 
> > tracing lockdep code at the same time the lockdep code is checking 
> > the tracer.
> ok ... you are right, i guess we need to go back to raw locks after 
> all?

I do like the fact that lockdep checks it too. But there's times that we 
can not do that.

Perhaps we can do something in between.

Make a rb_spin_lock macro inside ring_buffer.c that can be either a 
spin_lock or a raw_spin_lock.  There are some tracers that must have this 
as a raw (function trace, irqsoff and preemptoff), but the rest should be 
fine. We can make it where the rb_spin_lock is a raw lock when any of 
those three tracers are configured, and make it into a normal lock when 
they are not.

This way we can still test the integrity of the ring_buffer for other 
tracers. We just need to be careful when we are using function tracing or 
irqs/preempt off tracing. But we need to be careful with those anyway.

-- Steve

  reply	other threads:[~2008-11-05 16:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 12:37 Heiko Carstens
2008-11-05 13:07 ` Steven Rostedt
2008-11-05 16:04 ` Steven Rostedt
2008-11-05 16:30   ` Ingo Molnar
2008-11-05 16:47     ` Steven Rostedt [this message]
2008-11-05 17:01       ` Frédéric Weisbecker
2008-11-05 17:08       ` Ingo Molnar
2008-11-05 17:13         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: bug: ftrace & lockdep badness' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).