LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, npiggin@kernel.dk,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kosaki.motohiro@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [REPOST] [PATCH 3/3] Provide control over unmapped pages (v3)
Date: Fri, 21 Jan 2011 09:55:17 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1101210947270.13881@router.home> (raw)
In-Reply-To: <20110121072315.GL2897@balbir.in.ibm.com>

On Fri, 21 Jan 2011, Balbir Singh wrote:

> * Christoph Lameter <cl@linux.com> [2011-01-20 09:00:09]:
>
> > On Thu, 20 Jan 2011, Balbir Singh wrote:
> >
> > > +	unmapped_page_control
> > > +			[KNL] Available if CONFIG_UNMAPPED_PAGECACHE_CONTROL
> > > +			is enabled. It controls the amount of unmapped memory
> > > +			that is present in the system. This boot option plus
> > > +			vm.min_unmapped_ratio (sysctl) provide granular control
> >
> > min_unmapped_ratio is there to guarantee that zone reclaim does not
> > reclaim all unmapped pages.
> >
> > What you want here is a max_unmapped_ratio.
> >
>
> I thought about that, the logic for reusing min_unmapped_ratio was to
> keep a limit beyond which unmapped page cache shrinking should stop.

Right. That is the role of it. Its a minimum to leave. You want a maximum
size of the pagte cache.

> I think you are suggesting max_unmapped_ratio as the point at which
> shrinking should begin, right?

The role of min_unmapped_ratio is to never reclaim more pagecache if we
reach that ratio even if we have to go off node for an allocation.

AFAICT What you propose is a maximum size of the page cache. If the number
of page cache pages goes beyond that then you trim the page cache in
background reclaim.

> > > +			reclaim_unmapped_pages(priority, zone, &sc);
> > > +
> > >  			if (!zone_watermark_ok_safe(zone, order,
> >
> > Hmmmm. Okay that means background reclaim does it. If so then we also want
> > zone reclaim to be able to work in the background I think.
>
> Anything specific you had in mind, works for me in testing, but is
> there anything specific that stands out in your mind that needs to be
> done?

Hmmm. So this would also work in a NUMA configuration, right. Limiting the
sizes of the page cache would avoid zone reclaim through these limit. Page
cache size would be limited by the max_unmapped_ratio.

zone_reclaim only would come into play if other allocations make the
memory on the node so tight that we would have to evict more page
cache pages in direct reclaim.
Then zone_reclaim could go down to shrink the page cache size to
min_unmapped_ratio.




  reply	other threads:[~2011-01-21 15:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 12:36 [REPOST][PATCH 0/3] Unmapped page cache control (v3) Balbir Singh
2011-01-20 12:36 ` [REPOST] [PATCH 1/3] Move zone_reclaim() outside of CONFIG_NUMA (v3) Balbir Singh
2011-01-20 14:49   ` Christoph Lameter
2011-01-21  7:19     ` Balbir Singh
2011-01-20 12:36 ` [REPOST] [PATCH 2/3] Refactor zone_reclaim code (v3) Balbir Singh
2011-01-20 14:50   ` Christoph Lameter
2011-01-21  7:19     ` Balbir Singh
2011-01-20 12:36 ` [REPOST] [PATCH 3/3] Provide control over unmapped pages (v3) Balbir Singh
2011-01-20 15:00   ` Christoph Lameter
2011-01-21  7:23     ` Balbir Singh
2011-01-21 15:55       ` Christoph Lameter [this message]
2011-01-24  6:37         ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1101210947270.13881@router.home \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=npiggin@kernel.dk \
    --subject='Re: [REPOST] [PATCH 3/3] Provide control over unmapped pages (v3)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).