LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"x86@kernel.org" <x86@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jan Beulich <JBeulich@novell.com>
Subject: Re: [PATCH] x86/mm/init: respect memblock reserved regions when destroying mappings
Date: Mon, 7 Feb 2011 16:50:02 +0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1102071524140.7277@kaball-desktop> (raw)
In-Reply-To: <4D4EF553.6000000@kernel.org>
On Sun, 6 Feb 2011, Yinghai Lu wrote:
> On 02/05/2011 11:30 PM, H. Peter Anvin wrote:
> > On 02/05/2011 11:02 PM, Yinghai Lu wrote:
> >> why not just move calling cleanup_highmap down?
> >>
> >> something like attached patch.
> >
> > This patch looks very clean and looks on the surface of it like it is
> > removing some ugly ad hoc code, but (as always) it needs a description
> > about the problem it solves and why it is correct.
>
> Sure.
>
>
> Jeremy and xen guys, can you please check if it works well with xen ?
>
Actually this patch makes things worse on xen, because before
cleanup_highmap() wasn't called at all on xen (on purpose) and now it
is, fully destroying all the mappings we have at _end.
Can we add a check on memblock reserved regions in cleanup_highmap()?
Otherwise could we avoid calling cleanup_highmap() at all on xen?
next prev parent reply other threads:[~2011-02-07 16:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 15:18 Stefano Stabellini
2011-02-02 20:15 ` Jeremy Fitzhardinge
2011-02-03 5:05 ` H. Peter Anvin
2011-02-03 11:25 ` Stefano Stabellini
2011-02-03 17:02 ` H. Peter Anvin
2011-02-04 11:35 ` Stefano Stabellini
2011-02-05 1:18 ` Jeremy Fitzhardinge
2011-02-06 7:02 ` Yinghai Lu
2011-02-06 7:30 ` H. Peter Anvin
2011-02-06 17:49 ` Yinghai Lu
2011-02-06 19:24 ` Yinghai Lu
2011-02-07 16:50 ` Stefano Stabellini [this message]
2011-02-07 18:04 ` Yinghai Lu
2011-02-07 18:58 ` Stefano Stabellini
2011-02-07 19:00 ` Yinghai Lu
2011-02-07 19:18 ` Yinghai Lu
2011-02-07 21:56 ` Jeremy Fitzhardinge
2011-02-08 3:12 ` Yinghai Lu
2011-02-08 4:56 ` Jeremy Fitzhardinge
2011-02-08 5:09 ` Yinghai Lu
2011-02-08 14:55 ` Konrad Rzeszutek Wilk
2011-02-08 19:24 ` Jeremy Fitzhardinge
2011-02-08 20:26 ` Stefano Stabellini
2011-02-08 19:34 ` H. Peter Anvin
2011-02-10 23:48 ` Jeremy Fitzhardinge
2011-02-10 23:57 ` Yinghai Lu
2011-02-11 0:35 ` H. Peter Anvin
2011-02-11 0:54 ` Yinghai Lu
2011-02-14 16:26 ` Konrad Rzeszutek Wilk
2011-02-14 17:55 ` Yinghai Lu
2011-02-14 17:58 ` Stefano Stabellini
2011-02-14 18:09 ` Yinghai Lu
2011-02-14 20:02 ` H. Peter Anvin
2011-02-16 17:36 ` Stefano Stabellini
2011-02-07 19:00 ` Stefano Stabellini
2011-02-08 5:16 ` Yinghai Lu
2011-02-08 14:03 ` Stefano Stabellini
2011-02-08 16:04 ` Yinghai Lu
2011-02-07 16:02 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1102071524140.7277@kaball-desktop \
--to=stefano.stabellini@eu.citrix.com \
--cc=JBeulich@novell.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
--subject='Re: [PATCH] x86/mm/init: respect memblock reserved regions when destroying mappings' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).