LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Tony Lindgren <tony@atomide.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL
Date: Mon, 7 Feb 2011 20:09:34 -0700 (MST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1102072008480.21991@utopia.booyaka.com> (raw)
In-Reply-To: <87y66e3bc2.fsf_-_@vostro.fn.ogness.net>

On Fri, 21 Jan 2011, John Ogness wrote:

> From: John Ogness <john.ogness@linutronix.de>
> 
> In OMAP35X TRM Rev 2010-05 Figure 7-18 "DPLL With EMI Reduction
> Feature", it is shown that the internal frequency is calculated by
> CLK_IN/(N+1). However, the value passed to _dpll_test_fint() is
> already "N+1" since Linux is using the values to divide by. In the
> technical reference manual, "N" is referring to the divider's register
> value (0-127).
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Thanks for the patch, John.  Probably this should go into the -rc series 
since it could affect system stability, so will queue it there.


- Paul

      reply	other threads:[~2011-02-08  3:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 10:42 [PATCH] omap2: fix DPLL_FREQSEL calculation John Ogness
2011-01-20 11:16 ` Felipe Balbi
2011-01-20 14:29   ` [PATCH v2] " John Ogness
2011-01-21  3:15     ` Felipe Balbi
2011-01-21  8:33       ` [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL John Ogness
2011-02-08  3:09         ` Paul Walmsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1102072008480.21991@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=balbi@ti.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tony@atomide.com \
    --subject='Re: [PATCH v3] OMAP2/3: clock: fix fint calculation for DPLL_FREQSEL' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).