LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself
Date: Wed, 23 May 2012 17:36:38 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1205231735100.8785@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120523173342.GB4064@opensource.wolfsonmicro.com>

On Wed, 23 May 2012, Mark Brown wrote:

> > Multi-level pure selects *should* work correctly. So you can select
> > stuff that then in turn selects other stuff - and that should all be
> > fine.
> 
> They're supposed to, and mostly do, but there's been some fragility
> there.  That said there's not been anything recently, perhaps I just got
> hit with fallout from some development that was going on.
> 
> > It's *dependencies* that do not work.
> 
> Right, and nor are they supposed to since it's not clear what they
> should do.  That's a completely different thing.
> 

So my patch to select IRQ_DOMAIN for REGMAP_IRQ is correct since 
REGMAP_IRQ now requires IRC_DOMAIN since the commit listed in the 
changelog.

What's fragile is going around and adding "select IRQ_DOMAIN" to 
everything that does "select REGMAP_IRQ".  So I removed that and just made 
IRQ_DOMAIN select REGMAP_IRQ itself.

So can this be merged or what's the issue?

  reply	other threads:[~2012-05-24  0:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  8:30 linux-next: Tree for May 2 Stephen Rothwell
2012-05-22 11:28 ` Stephen Rothwell
2012-05-22 15:22 ` linux-next: Tree for May 2 (regmap-irq) Randy Dunlap
2012-05-23  6:57   ` [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself David Rientjes
2012-05-23  9:32     ` Mark Brown
2012-05-23 15:51       ` Linus Torvalds
2012-05-23 17:33         ` Mark Brown
2012-05-24  0:36           ` David Rientjes [this message]
2012-05-24  1:12             ` David Rientjes
2012-05-24  9:37               ` Mark Brown
2012-05-24  1:19             ` Mark Brown
2012-05-24  4:53               ` David Rientjes
2012-05-24  9:09                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1205231735100.8785@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN itself' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).