LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Walmsley <paul@pwsan.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
	Thierry Reding <treding@nvidia.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: arm64: USB_ARCH_HAS_EHCI
Date: Wed, 28 Jan 2015 16:25:04 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.02.1501281621330.19947@utopia.booyaka.com> (raw)
In-Reply-To: <1422438405.5666.16.camel@x220>

On Wed, 28 Jan 2015, Paul Bolle wrote:

> On Tue, 2015-01-27 at 21:31 +0000, Paul Walmsley wrote:
> > On Tue, 27 Jan 2015, Paul Bolle wrote:
> > 
> > > Your commit d035fdfa27ac ("arm64: Add Tegra132 support") is included in
> > > today's linux-next (ie, next-20150127). I noticed because a script I use
> > > to check linux-next spotted a minor problem with it.
> > > 
> > > It adds a select for the Kconfig symbol USB_ARCH_HAS_EHCI. That Kconfig
> > > was obsoleted in v3.11 and removed in v3.15. See commit b797b76fb464
> > > ("usb: host: remove USB_ARCH_HAS_?HCI"). That select is now a nop.
> > > 
> > > Should I submit the trivial patch to remove that line or do you prefer
> > > to do that yourself?
> > 
> > Thanks, I'll post a new version.
> 
> I just noticed that your commit added another unneeded select. The entry
> for ARCH_TEGRA selects HAVE_SMP, but HAVE_SMP is only available on arm
> or xtensa. There's no point in selecting it in arm64.

OK thanks, will roll that in.  Looks like Thierry's already sent a pull 
request for the original patch, so I'll probably just send a follow-up.

Is the Kconfig checker script you mentioned on Tuesday available in the 
mainline tree?  I don't see anything obvious under the "Static Analysers" 
section of the Makefile, but perhaps I'm overlooking it.


- Paul

  parent reply	other threads:[~2015-01-28 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  9:43 Paul Bolle
2015-01-27 21:31 ` Paul Walmsley
     [not found]   ` <1422438405.5666.16.camel@x220>
2015-01-28 16:25     ` Paul Walmsley [this message]
2015-01-28 21:00       ` Paul Bolle
2015-01-28 21:12         ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1501281621330.19947@utopia.booyaka.com \
    --to=paul@pwsan.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=treding@nvidia.com \
    --cc=valentinrothberg@gmail.com \
    --cc=will.deacon@arm.com \
    --subject='Re: arm64: USB_ARCH_HAS_EHCI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).