LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Jens Axboe <axboe@fb.com>, Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-user@lists.linbit.com
Subject: [patch 2/2] block, drbd: use mempool_create_slab_pool()
Date: Sat, 7 Mar 2015 16:24:30 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1503071624160.31688@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1503071623250.31688@chino.kir.corp.google.com>

Mempools created for slab caches should use
mempool_create_slab_pool().

Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Jens Axboe <axboe@fb.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 drivers/block/drbd/drbd_main.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -2107,13 +2107,12 @@ static int drbd_create_mempools(void)
 	if (drbd_md_io_page_pool == NULL)
 		goto Enomem;
 
-	drbd_request_mempool = mempool_create(number,
-		mempool_alloc_slab, mempool_free_slab, drbd_request_cache);
+	drbd_request_mempool = mempool_create_slab_pool(number,
+		drbd_request_cache);
 	if (drbd_request_mempool == NULL)
 		goto Enomem;
 
-	drbd_ee_mempool = mempool_create(number,
-		mempool_alloc_slab, mempool_free_slab, drbd_ee_cache);
+	drbd_ee_mempool = mempool_create_slab_pool(number, drbd_ee_cache);
 	if (drbd_ee_mempool == NULL)
 		goto Enomem;
 

  reply	other threads:[~2015-03-08  0:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08  0:24 [patch 1/2] block, drbd: fix drbd_req_new() initialization David Rientjes
2015-03-08  0:24 ` David Rientjes [this message]
2015-03-08  0:33 ` Jens Axboe
2015-03-08  0:53   ` David Rientjes
2015-03-08  1:03     ` Jens Axboe
2015-03-08  1:27       ` David Rientjes
2015-03-08  1:45         ` Jens Axboe
2015-03-13 23:24         ` David Rientjes
2015-03-10 10:38 ` [DRBD-user] " Lars Ellenberg
2015-03-10 19:28   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1503071624160.31688@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=axboe@fb.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=drbd-user@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [patch 2/2] block, drbd: use mempool_create_slab_pool()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).