LKML Archive on
help / color / mirror / Atom feed
From: David Rientjes <>
To: Andrew Morton <>
Cc: Naoya Horiguchi <>,
	Davidlohr Bueso <>,
	"Kirill A. Shutemov" <>,,
Subject: [patch v2] mm, hugetlb: abort __get_user_pages if current has been oom killed
Date: Mon, 9 Mar 2015 00:42:15 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

If __get_user_pages() is faulting a significant number of hugetlb pages,
usually as the result of mmap(MAP_LOCKED), it can potentially allocate a
very large amount of memory.

If the process has been oom killed, this will cause a lot of memory to
be overcharged to its memcg since it has access to memory reserves or
could potentially deplete all system memory reserves.

In the same way that commit 4779280d1ea4 ("mm: make get_user_pages() 
interruptible") aborted for pending SIGKILLs when faulting non-hugetlb
memory, based on the premise of commit 462e00cc7151 ("oom: stop
allocating user memory if TIF_MEMDIE is set"), hugetlb page faults now
terminate when the process has been oom killed.

Cc: Naoya Horiguchi <>
Cc: Davidlohr Bueso <>
Cc: "Kirill A. Shutemov" <>
Signed-off-by: David Rientjes <>
 v2: check signal inside follow_huegtlb_page() loop per Kirill

 mm/hugetlb.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3276,6 +3276,15 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
 		struct page *page;
+		 * If we have a pending SIGKILL, don't keep faulting pages and
+		 * potentially allocating memory.
+		 */
+		if (unlikely(fatal_signal_pending(current))) {
+			remainder = 0;
+			break;
+		}
+		/*
 		 * Some archs (sparc64, sh*) have multiple pte_ts to
 		 * each hugepage.  We have to make sure we get the
 		 * first, for the page indexing below to work.

  reply	other threads:[~2015-03-09  7:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08 23:12 [patch] " David Rientjes
2015-03-09  4:30 ` Kirill A. Shutemov
2015-03-09  7:42   ` David Rientjes [this message]
2015-03-09 11:24     ` [patch v2] " Kirill A. Shutemov
2015-03-09 12:04     ` Greg Thelen
2015-03-09 20:07       ` [patch v3] " David Rientjes
2015-03-09 20:53         ` Rik van Riel
2015-03-10  0:47         ` Greg Thelen
2015-03-10 19:26         ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [patch v2] mm, hugetlb: abort __get_user_pages if current has been oom killed' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).