LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [patch] mm, hugetlb: abort __get_user_pages if current has been oom killed
@ 2015-03-08 23:12 David Rientjes
  2015-03-09  4:30 ` Kirill A. Shutemov
  0 siblings, 1 reply; 9+ messages in thread
From: David Rientjes @ 2015-03-08 23:12 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Kirill A. Shutemov, linux-kernel, linux-mm

If __get_user_pages() is faulting a significant number of hugetlb pages,
usually as the result of mmap(MAP_LOCKED), it can potentially allocate a
very large amount of memory.

If the process has been oom killed, this will cause a lot of memory to
be overcharged to its memcg since it has access to memory reserves or
could potentially deplete all system memory reserves.

In the same way that commit 4779280d1ea4 ("mm: make get_user_pages() 
interruptible") aborted for pending SIGKILLs when faulting non-hugetlb
memory, based on the premise of commit 462e00cc7151 ("oom: stop
allocating user memory if TIF_MEMDIE is set"), hugetlb page faults now
terminate when the process has been oom killed.

Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/gup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/gup.c b/mm/gup.c
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -457,6 +457,8 @@ long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
 			if (!vma || check_vma_flags(vma, gup_flags))
 				return i ? : -EFAULT;
 			if (is_vm_hugetlb_page(vma)) {
+				if (unlikely(fatal_signal_pending(current)))
+					return i ? : -ERESTARTSYS;
 				i = follow_hugetlb_page(mm, vma, pages, vmas,
 						&start, &nr_pages, i,
 						gup_flags);

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-03-10 19:26 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-08 23:12 [patch] mm, hugetlb: abort __get_user_pages if current has been oom killed David Rientjes
2015-03-09  4:30 ` Kirill A. Shutemov
2015-03-09  7:42   ` [patch v2] " David Rientjes
2015-03-09 11:24     ` Kirill A. Shutemov
2015-03-09 12:04     ` Greg Thelen
2015-03-09 20:07       ` [patch v3] " David Rientjes
2015-03-09 20:53         ` Rik van Riel
2015-03-10  0:47         ` Greg Thelen
2015-03-10 19:26         ` Davidlohr Bueso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).