From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbbCKTUM (ORCPT ); Wed, 11 Mar 2015 15:20:12 -0400 Received: from smtp2.kfki.hu ([148.6.0.28]:42307 "EHLO smtp2.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbCKTUK (ORCPT ); Wed, 11 Mar 2015 15:20:10 -0400 Date: Wed, 11 Mar 2015 20:21:58 +0100 (CET) From: Jozsef Kadlecsik To: Pablo Neira Ayuso cc: kbuild test robot , kbuild-all@01.org, Patrick McHardy , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: ipset: fix boolreturn.cocci warnings In-Reply-To: <20150311191240.GA9577@salvia> Message-ID: References: <201502112043.OvntWCjd%fengguang.wu@intel.com> <20150211123305.GA32347@waimea> <20150311191240.GA9577@salvia> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2015, Pablo Neira Ayuso wrote: > Hi Jozsef, > > On Wed, Mar 11, 2015 at 08:08:26PM +0100, Jozsef Kadlecsik wrote: > > On Wed, 11 Feb 2015, kbuild test robot wrote: > > > > > net/netfilter/xt_set.c:196:9-10: WARNING: return of 0/1 in function 'set_match_v3' with return type bool > > > net/netfilter/xt_set.c:242:9-10: WARNING: return of 0/1 in function 'set_match_v4' with return type bool > > > > > > Return statements in functions returning bool should use > > > true/false instead of 1/0. > > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > > > > > CC: Jozsef Kadlecsik > > > Signed-off-by: Fengguang Wu > > > > Patch is applied, thanks. > > I took the liberty to pass this to David already. > > 7f73b9f netfilter: ipset: fix boolreturn.cocci warnings I acked it actually :-))) - just forgot about it. Sorry for the noise. Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary