LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] genirq: Allow irq_desc to carry the union of stacked irq_chip flags
Date: Fri, 23 Jan 2015 16:55:15 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1501231648110.5526@nanos> (raw)
In-Reply-To: <1421246717-11640-3-git-send-email-marc.zyngier@arm.com>

On Wed, 14 Jan 2015, Marc Zyngier wrote:

> The current infrastructure for stacked domains doesn't propagate
> irq_chip flags, and as we only look at the top-level irq_chip,
> we may miss a number of critical flags.
> 
> This patch accumulates the flags into a new set, stored at the
> irq_desc level, with an additional flag to indicate that this is
> a stack of irqchip. The accessor is updated to return the right one.

>  static inline unsigned long irq_desc_get_chip_flags(struct irq_desc *desc)
>  {
> +#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
> +	if (desc->chip_flags & IRQCHIP_STACKED_CHIPS)
> +		return desc->chip_flags;
> +#endif
>  	return desc->irq_data.chip->flags;

We can avoid the extra conditional if we just make the accumulated
flags unconditional and collect them even for the !hierarchy case.

Also this patch is missing that chips can be swapped at runtime either
via the normal interfaces or via __irq_set_chip_handler_name_locked().

This needs to be addressed otherwise we might end up looking at the
wrong flags.

Thanks,

	tglx

  reply	other threads:[~2015-01-23 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 14:45 [PATCH v2 0/2] genirq: Make irqchip flags work with stacked irq domains Marc Zyngier
2015-01-14 14:45 ` [PATCH v2 1/2] genirq: Abstract access to irq_chip flags Marc Zyngier
2015-01-14 14:45 ` [PATCH v2 2/2] genirq: Allow irq_desc to carry the union of stacked " Marc Zyngier
2015-01-23 15:55   ` Thomas Gleixner [this message]
2015-01-24  0:43     ` Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1501231648110.5526@nanos \
    --to=tglx@linutronix.de \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --subject='Re: [PATCH v2 2/2] genirq: Allow irq_desc to carry the union of stacked irq_chip flags' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).