LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs
@ 2015-01-22  9:48 Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
                   ` (7 more replies)
  0 siblings, 8 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

Rebased and resending, as requested by Jason.

This driver enables IRQs which are controlled using System Configuration
registers.  Without it Performance Monitoring, Core Sight Tracing and some
L2 Caches will fail to function.

v1 => v2:
 - Fixed up Jason's review comments

Lee Jones (8):
  dt: bindings: Supply shared ST IRQ defines
  irqchip: Supply new driver for STi based devices
  irqchip: irq-st: Add documentation for STi based syscfg IRQs
  ARM: STi: STiH416: Enable Cortex-A9 PMU support
  ARM: STi: STiH416: Enable PMU IRQs
  ARM: STi: STiH407: Enable Cortex-A9 PMU support
  ARM: STi: STiH407: Enable PMU IRQs
  ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at
    boot

 .../interrupt-controller/st,sti-irq-syscfg.txt     |  35 ++++
 arch/arm/boot/dts/stih407-family.dtsi              |  16 ++
 arch/arm/boot/dts/stih416.dtsi                     |  16 ++
 arch/arm/mach-sti/Kconfig                          |   1 +
 drivers/irqchip/Kconfig                            |   7 +
 drivers/irqchip/Makefile                           |   1 +
 drivers/irqchip/irq-st.c                           | 208 +++++++++++++++++++++
 include/dt-bindings/interrupt-controller/irq-st.h  |  30 +++
 8 files changed, 314 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt
 create mode 100644 drivers/irqchip/irq-st.c
 create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h

-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-23 15:58   ` Thomas Gleixner
  2015-01-22  9:48 ` [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices Lee Jones
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

These defines are used to allow values used for configuration to be
easily human readable and will lessen the chance of logical mistakes.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h

diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h
new file mode 100644
index 0000000..4c59ace
--- /dev/null
+++ b/include/dt-bindings/interrupt-controller/irq-st.h
@@ -0,0 +1,30 @@
+/*
+ *  include/linux/irqchip/irq-st.h
+ *
+ *  Copyright (C) 2014 STMicroelectronics – All Rights Reserved
+ *
+ *  Author: Lee Jones <lee.jones@linaro.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_ST_H
+#define _DT_BINDINGS_INTERRUPT_CONTROLLER_ST_H
+
+#define ST_IRQ_SYSCFG_EXT_0		0
+#define ST_IRQ_SYSCFG_EXT_1		1
+#define ST_IRQ_SYSCFG_EXT_2		2
+#define ST_IRQ_SYSCFG_CTI_0		3
+#define ST_IRQ_SYSCFG_CTI_1		4
+#define ST_IRQ_SYSCFG_PMU_0		5
+#define ST_IRQ_SYSCFG_PMU_1		6
+#define ST_IRQ_SYSCFG_pl310_L2		7
+#define ST_IRQ_SYSCFG_DISABLED		0xFFFFFFFF
+
+#define ST_IRQ_SYSCFG_EXT_1_INV		0x1
+#define ST_IRQ_SYSCFG_EXT_2_INV		0x2
+#define ST_IRQ_SYSCFG_EXT_3_INV		0x4
+
+#endif
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-23 16:10   ` Thomas Gleixner
  2015-01-22  9:48 ` [PATCH v2 RESEND 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
                   ` (5 subsequent siblings)
  7 siblings, 1 reply; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

This driver is used to enable System Configuration Register controlled
External, CTI (Core Sight), PMU (Performance Management), and PL310 L2
Cache IRQs prior to use.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/irqchip/Kconfig  |   7 ++
 drivers/irqchip/Makefile |   1 +
 drivers/irqchip/irq-st.c | 208 +++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 216 insertions(+)
 create mode 100644 drivers/irqchip/irq-st.c

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index cc79d2a..c8d260e 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -110,6 +110,13 @@ config RENESAS_IRQC
 	bool
 	select IRQ_DOMAIN
 
+config ST_IRQCHIP
+	bool
+	select REGMAP
+	select MFD_SYSCON
+	help
+	  Enables SysCfg Controlled IRQs on STi based platforms.
+
 config TB10X_IRQC
 	bool
 	select IRQ_DOMAIN
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 9516a32..4023f22 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -33,6 +33,7 @@ obj-$(CONFIG_RENESAS_IRQC)		+= irq-renesas-irqc.o
 obj-$(CONFIG_VERSATILE_FPGA_IRQ)	+= irq-versatile-fpga.o
 obj-$(CONFIG_ARCH_NSPIRE)		+= irq-zevio.o
 obj-$(CONFIG_ARCH_VT8500)		+= irq-vt8500.o
+obj-$(CONFIG_ST_IRQCHIP)		+= irq-st.o
 obj-$(CONFIG_TB10X_IRQC)		+= irq-tb10x.o
 obj-$(CONFIG_XTENSA)			+= irq-xtensa-pic.o
 obj-$(CONFIG_XTENSA_MX)			+= irq-xtensa-mx.o
diff --git a/drivers/irqchip/irq-st.c b/drivers/irqchip/irq-st.c
new file mode 100644
index 0000000..f1662c0
--- /dev/null
+++ b/drivers/irqchip/irq-st.c
@@ -0,0 +1,208 @@
+/*
+ *  drivers/irqchip/irq-st.c
+ *
+ *  Copyright (C) 2014 STMicroelectronics – All Rights Reserved
+ *
+ *  Author: Lee Jones <lee.jones@linaro.org>
+ *
+ *  This is a re-write of Christophe Kerello's PMU driver.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <dt-bindings/interrupt-controller/irq-st.h>
+#include <linux/err.h>
+#include <linux/mfd/syscon.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+
+#define STIH415_SYSCFG_642		0x0a8
+#define STIH416_SYSCFG_7543		0x87c
+#define STIH407_SYSCFG_5102		0x198
+#define STID127_SYSCFG_734		0x088
+
+#define ST_A9_IRQ_MASK			0x001FFFFF
+#define ST_A9_IRQ_MAX_CHANS		2
+
+#define ST_A9_IRQ_EN_CTI_0		BIT(0)
+#define ST_A9_IRQ_EN_CTI_1		BIT(1)
+#define ST_A9_IRQ_EN_PMU_0		BIT(2)
+#define ST_A9_IRQ_EN_PMU_1		BIT(3)
+#define ST_A9_IRQ_EN_PL310_L2		BIT(4)
+#define ST_A9_IRQ_EN_EXT_0		BIT(5)
+#define ST_A9_IRQ_EN_EXT_1		BIT(6)
+#define ST_A9_IRQ_EN_EXT_2		BIT(7)
+
+#define ST_A9_FIQ_N_SEL(dev, chan)	(dev << (8  + (chan * 3)))
+#define ST_A9_IRQ_N_SEL(dev, chan)	(dev << (14 + (chan * 3)))
+#define ST_A9_EXTIRQ_INV_SEL(dev)	(dev << 20)
+
+struct st_irq_syscfg {
+	struct regmap *regmap;
+	unsigned int syscfg;
+	unsigned int config;
+	bool ext_inverted;
+};
+
+static const struct of_device_id st_irq_syscfg_match[] = {
+	{
+		.compatible = "st,stih415-irq-syscfg",
+		.data = (void *)STIH415_SYSCFG_642,
+	},
+	{
+		.compatible = "st,stih416-irq-syscfg",
+		.data = (void *)STIH416_SYSCFG_7543,
+	},
+	{
+		.compatible = "st,stih407-irq-syscfg",
+		.data = (void *)STIH407_SYSCFG_5102,
+	},
+	{
+		.compatible = "st,stid127-irq-syscfg",
+		.data = (void *)STID127_SYSCFG_734,
+	},
+	{}
+};
+
+static int st_irq_xlate(struct platform_device *pdev,
+			int device, int channel, bool irq)
+{
+	struct st_irq_syscfg *ddata = dev_get_drvdata(&pdev->dev);
+
+	/* Set the device enable bit. */
+	switch (device) {
+	case ST_IRQ_SYSCFG_EXT_0:
+		ddata->config |= ST_A9_IRQ_EN_EXT_0;
+		break;
+	case ST_IRQ_SYSCFG_EXT_1:
+		ddata->config |= ST_A9_IRQ_EN_EXT_1;
+		break;
+	case ST_IRQ_SYSCFG_EXT_2:
+		ddata->config |= ST_A9_IRQ_EN_EXT_2;
+		break;
+	case ST_IRQ_SYSCFG_CTI_0:
+		ddata->config |= ST_A9_IRQ_EN_CTI_0;
+		break;
+	case ST_IRQ_SYSCFG_CTI_1:
+		ddata->config |= ST_A9_IRQ_EN_CTI_1;
+		break;
+	case ST_IRQ_SYSCFG_PMU_0:
+		ddata->config |= ST_A9_IRQ_EN_PMU_0;
+		break;
+	case ST_IRQ_SYSCFG_PMU_1:
+		ddata->config |= ST_A9_IRQ_EN_PMU_1;
+		break;
+	case ST_IRQ_SYSCFG_pl310_L2:
+		ddata->config |= ST_A9_IRQ_EN_PL310_L2;
+		break;
+	case ST_IRQ_SYSCFG_DISABLED:
+		return 0;
+	default:
+		dev_err(&pdev->dev, "Unrecognised device %d\n", device);
+		return -EINVAL;
+	}
+
+	/* Select IRQ/FIQ channel for device. */
+	ddata->config |= irq ?
+		ST_A9_IRQ_N_SEL(device, channel) :
+		ST_A9_FIQ_N_SEL(device, channel);
+
+	return 0;
+}
+
+static int st_irq_syscfg_enable(struct platform_device *pdev)
+{
+	struct device_node *np = pdev->dev.of_node;
+	struct st_irq_syscfg *ddata = dev_get_drvdata(&pdev->dev);
+	int channels, ret, i;
+	u32 device, invert;
+
+	channels = of_property_count_u32_elems(np, "st,irq-device");
+	if (channels != ST_A9_IRQ_MAX_CHANS) {
+		dev_err(&pdev->dev, "st,enable-irq-device must have 2 elems\n");
+		return -EINVAL;
+	}
+
+	channels = of_property_count_u32_elems(np, "st,fiq-device");
+	if (channels != ST_A9_IRQ_MAX_CHANS) {
+		dev_err(&pdev->dev, "st,enable-fiq-device must have 2 elems\n");
+		return -EINVAL;
+	}
+
+	for (i = 0; i < ST_A9_IRQ_MAX_CHANS; i++) {
+		of_property_read_u32_index(np, "st,irq-device", i, &device);
+
+		ret = st_irq_xlate(pdev, device, i, true);
+		if (ret)
+			return ret;
+
+		of_property_read_u32_index(np, "st,fiq-device", i, &device);
+
+		ret = st_irq_xlate(pdev, device, i, false);
+		if (ret)
+			return ret;
+	}
+
+	/* External IRQs may be inverted. */
+	of_property_read_u32(np, "st,invert-ext", &invert);
+	ddata->config |= ST_A9_EXTIRQ_INV_SEL(invert);
+
+	return regmap_update_bits(ddata->regmap, ddata->syscfg,
+				  ST_A9_IRQ_MASK, ddata->config);
+}
+
+static int st_irq_syscfg_probe(struct platform_device *pdev)
+{
+	struct device_node *np = pdev->dev.of_node;
+	const struct of_device_id *match;
+	struct st_irq_syscfg *ddata;
+
+	ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
+	if (!ddata)
+		return -ENOMEM;
+
+	match = of_match_device(st_irq_syscfg_match, &pdev->dev);
+	if (!match)
+		return -ENODEV;
+
+	ddata->syscfg = (unsigned int)match->data;
+
+	ddata->regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
+	if (IS_ERR(ddata->regmap)) {
+		dev_err(&pdev->dev, "syscfg phandle missing\n");
+		return PTR_ERR(ddata->regmap);
+	}
+
+	dev_set_drvdata(&pdev->dev, ddata);
+
+	return st_irq_syscfg_enable(pdev);
+}
+
+static int st_irq_syscfg_resume(struct device *dev)
+{
+	struct st_irq_syscfg *ddata = dev_get_drvdata(dev);
+
+	return regmap_update_bits(ddata->regmap, ddata->syscfg,
+				  ST_A9_IRQ_MASK, ddata->config);
+}
+
+static SIMPLE_DEV_PM_OPS(st_irq_syscfg_pm_ops, NULL, st_irq_syscfg_resume);
+
+static struct platform_driver st_irq_syscfg_driver = {
+	.driver = {
+		.name = "st_irq_syscfg",
+		.pm = &st_irq_syscfg_pm_ops,
+		.of_match_table = st_irq_syscfg_match,
+	},
+	.probe = st_irq_syscfg_probe,
+};
+
+static int __init st_irq_syscfg_init(void)
+{
+	return platform_driver_register(&st_irq_syscfg_driver);
+}
+core_initcall(st_irq_syscfg_init);
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

Cc: devicetree@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 .../interrupt-controller/st,sti-irq-syscfg.txt     | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt

diff --git a/Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt b/Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt
new file mode 100644
index 0000000..ced6014
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/st,sti-irq-syscfg.txt
@@ -0,0 +1,35 @@
+STMicroelectronics STi System Configuration Controlled IRQs
+-----------------------------------------------------------
+
+On STi based systems; External, CTI (Core Sight), PMU (Performance Management),
+and PL310 L2 Cache IRQs are controlled using System Configuration registers.
+This driver is used to unmask them prior to use.
+
+Required properties:
+- compatible	: Should be set to one of:
+			"st,stih415-irq-syscfg"
+			"st,stih416-irq-syscfg"
+			"st,stih407-irq-syscfg"
+			"st,stid127-irq-syscfg"
+- st,syscfg	: Phandle to Cortex-A9 IRQ system config registers
+- st,irq-device	: Array of IRQs to enable - should be 2 in length
+- st,fiq-device	: Array of FIQs to enable - should be 2 in length
+
+Optional properties:
+- st,invert-ext	: External IRQs can be inverted at will.  This property inverts
+		  these IRQs using bitwise logic.  A number of defines have been
+		  provided for convenience:
+			ST_IRQ_SYSCFG_EXT_1_INV
+			ST_IRQ_SYSCFG_EXT_2_INV
+			ST_IRQ_SYSCFG_EXT_3_INV
+Example:
+
+irq-syscfg {
+	compatible    = "st,stih416-irq-syscfg";
+	st,syscfg     = <&syscfg_cpu>;
+	st,irq-device = <ST_IRQ_SYSCFG_PMU_0>,
+			<ST_IRQ_SYSCFG_PMU_1>;
+	st,fiq-device = <ST_IRQ_SYSCFG_DISABLED>,
+			<ST_IRQ_SYSCFG_DISABLED>;
+	st,invert-ext = <(ST_IRQ_SYSCFG_EXT_1_INV | ST_IRQ_SYSCFG_EXT_3_INV)>;
+};
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
                   ` (2 preceding siblings ...)
  2015-01-22  9:48 ` [PATCH v2 RESEND 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 5/8] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

This is ARM's generic Performance Monitoring Unit.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/stih416.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index fad9073..cdbf29c 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -23,6 +23,12 @@
 		cache-level = <2>;
 	};
 
+	arm-pmu {
+		compatible = "arm,cortex-a9-pmu";
+		interrupt-parent = <&intc>;
+		interrupts = <GIC_PPI 15 IRQ_TYPE_LEVEL_HIGH>;
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 5/8] ARM: STi: STiH416: Enable PMU IRQs
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
                   ` (3 preceding siblings ...)
  2015-01-22  9:48 ` [PATCH v2 RESEND 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support Lee Jones
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

This driver is used to enable System Configuration Register controlled
External, CTI (Core Sight), PMU (Performance Management), and PL310 L2
Cache IRQs prior to use.

Here we are enabling PMU IRQs on both channels.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/stih416.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/stih416.dtsi b/arch/arm/boot/dts/stih416.dtsi
index cdbf29c..de2afb9 100644
--- a/arch/arm/boot/dts/stih416.dtsi
+++ b/arch/arm/boot/dts/stih416.dtsi
@@ -13,6 +13,7 @@
 #include <dt-bindings/phy/phy-miphy365x.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/reset-controller/stih416-resets.h>
+#include <dt-bindings/interrupt-controller/irq-st.h>
 / {
 	L2: cache-controller {
 		compatible = "arm,pl310-cache";
@@ -92,6 +93,15 @@
 			reg		= <0xfe4b5100 0x8>;
 		};
 
+		irq-syscfg {
+			compatible    = "st,stih416-irq-syscfg";
+			st,syscfg     = <&syscfg_cpu>;
+			st,irq-device = <ST_IRQ_SYSCFG_PMU_0>,
+					<ST_IRQ_SYSCFG_PMU_1>;
+			st,fiq-device = <ST_IRQ_SYSCFG_DISABLED>,
+					<ST_IRQ_SYSCFG_DISABLED>;
+		};
+
 		serial2: serial@fed32000{
 			compatible	= "st,asc";
 			status 		= "disabled";
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
                   ` (4 preceding siblings ...)
  2015-01-22  9:48 ` [PATCH v2 RESEND 5/8] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 7/8] ARM: STi: STiH407: Enable PMU IRQs Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones
  7 siblings, 0 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

This is ARM's generic Performance Monitoring Unit.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/stih407-family.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 3e31d32..939e46e 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -56,6 +56,12 @@
 		cache-level = <2>;
 	};
 
+	arm-pmu {
+		interrupt-parent = <&intc>;
+		compatible = "arm,cortex-a9-pmu";
+		interrupts = <GIC_PPI 15 IRQ_TYPE_LEVEL_HIGH>;
+	};
+
 	soc {
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 7/8] ARM: STi: STiH407: Enable PMU IRQs
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
                   ` (5 preceding siblings ...)
  2015-01-22  9:48 ` [PATCH v2 RESEND 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  2015-01-22  9:48 ` [PATCH v2 RESEND 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones
  7 siblings, 0 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

This driver is used to enable System Configuration Register controlled
External, CTI (Core Sight), PMU (Performance Management), and PL310 L2
Cache IRQs prior to use.

Here we are enabling PMU IRQs on both channels.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/boot/dts/stih407-family.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index 939e46e..aa86d99 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -8,6 +8,7 @@
  */
 #include "stih407-pinctrl.dtsi"
 #include <dt-bindings/reset-controller/stih407-resets.h>
+#include <dt-bindings/interrupt-controller/irq-st.h>
 / {
 	#address-cells = <1>;
 	#size-cells = <1>;
@@ -119,6 +120,15 @@
 			reg = <0x94b5100 0x1000>;
 		};
 
+		irq-syscfg {
+			compatible    = "st,stih407-irq-syscfg";
+			st,syscfg     = <&syscfg_core>;
+			st,irq-device = <ST_IRQ_SYSCFG_PMU_0>,
+					<ST_IRQ_SYSCFG_PMU_1>;
+			st,fiq-device = <ST_IRQ_SYSCFG_DISABLED>,
+					<ST_IRQ_SYSCFG_DISABLED>;
+		};
+
 		serial@9830000 {
 			compatible = "st,asc";
 			reg = <0x9830000 0x2c>;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 RESEND 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot
  2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
                   ` (6 preceding siblings ...)
  2015-01-22  9:48 ` [PATCH v2 RESEND 7/8] ARM: STi: STiH407: Enable PMU IRQs Lee Jones
@ 2015-01-22  9:48 ` Lee Jones
  7 siblings, 0 replies; 15+ messages in thread
From: Lee Jones @ 2015-01-22  9:48 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel; +Cc: lee.jones, kernel, tglx, jason, devicetree

This driver is used to enable System Configuration Register controlled
External, CTI (Core Sight), PMU (Performance Management), and PL310 L2
Cache IRQs prior to use.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/mach-sti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-sti/Kconfig b/arch/arm/mach-sti/Kconfig
index 8825bc9..5d8b3f8 100644
--- a/arch/arm/mach-sti/Kconfig
+++ b/arch/arm/mach-sti/Kconfig
@@ -1,6 +1,7 @@
 menuconfig ARCH_STI
 	bool "STMicroelectronics Consumer Electronics SOCs" if ARCH_MULTI_V7
 	select ARM_GIC
+	select ST_IRQCHIP
 	select ARM_GLOBAL_TIMER
 	select PINCTRL
 	select PINCTRL_ST
-- 
1.9.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines
  2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
@ 2015-01-23 15:58   ` Thomas Gleixner
  2015-01-23 16:39     ` Lee Jones
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Gleixner @ 2015-01-23 15:58 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, kernel, jason, devicetree

On Thu, 22 Jan 2015, Lee Jones wrote:

> These defines are used to allow values used for configuration to be
> easily human readable and will lessen the chance of logical mistakes.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h
> 
> diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h
> new file mode 100644
> index 0000000..4c59ace
> --- /dev/null
> +++ b/include/dt-bindings/interrupt-controller/irq-st.h
> @@ -0,0 +1,30 @@
> +/*
> + *  include/linux/irqchip/irq-st.h

Copy & Paste?

Can we please stop adding these pointless filenames all over the
place? They are useless and wrong in a lot of cases.

Aside of that, this needs an ack from the DT folks.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices
  2015-01-22  9:48 ` [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices Lee Jones
@ 2015-01-23 16:10   ` Thomas Gleixner
  2015-01-23 16:32     ` Lee Jones
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Gleixner @ 2015-01-23 16:10 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, kernel, jason, devicetree

On Thu, 22 Jan 2015, Lee Jones wrote:

> This driver is used to enable System Configuration Register controlled
> External, CTI (Core Sight), PMU (Performance Management), and PL310 L2
> Cache IRQs prior to use.

I'm wondering how this is related to irq_chip, but well, I don't mind
it being parked here.

Though I really cannot say anything about this DT translation
machinery for a single sysconfig register, other than it looks
completely overengineered to me.

The only technical comment I have is: shouldn't all the stuff except
the resume function be marked __init or is any of this required post
init?

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices
  2015-01-23 16:10   ` Thomas Gleixner
@ 2015-01-23 16:32     ` Lee Jones
  2015-01-24 11:48       ` Thomas Gleixner
  0 siblings, 1 reply; 15+ messages in thread
From: Lee Jones @ 2015-01-23 16:32 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-arm-kernel, linux-kernel, kernel, jason, devicetree

On Fri, 23 Jan 2015, Thomas Gleixner wrote:
> On Thu, 22 Jan 2015, Lee Jones wrote:
> 
> > This driver is used to enable System Configuration Register controlled
> > External, CTI (Core Sight), PMU (Performance Management), and PL310 L2
> > Cache IRQs prior to use.
> 
> I'm wondering how this is related to irq_chip, 

It doesn't really.  At least, it doesn't make use of the framework.  
It was the most relevant subsystem.

> but well, I don't mind it being parked here.

Thanks Thomas.  I was hoping for that response.

> Though I really cannot say anything about this DT translation
> machinery for a single sysconfig register, other than it looks
> completely overengineered to me.

I understnad where you're coming from, but don't all drivers just
'twiddle some register bits'?

> The only technical comment I have is: shouldn't all the stuff except
> the resume function be marked __init or is any of this required post
> init?

It's not common to mark functions invoked at and affter *_probe() as
__init.  At least, not as far as I'm aware.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines
  2015-01-23 15:58   ` Thomas Gleixner
@ 2015-01-23 16:39     ` Lee Jones
  2015-01-24 11:46       ` Thomas Gleixner
  0 siblings, 1 reply; 15+ messages in thread
From: Lee Jones @ 2015-01-23 16:39 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-arm-kernel, linux-kernel, kernel, jason, devicetree

On Fri, 23 Jan 2015, Thomas Gleixner wrote:

> On Thu, 22 Jan 2015, Lee Jones wrote:
> 
> > These defines are used to allow values used for configuration to be
> > easily human readable and will lessen the chance of logical mistakes.
> > 
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> >  create mode 100644 include/dt-bindings/interrupt-controller/irq-st.h
> > 
> > diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/include/dt-bindings/interrupt-controller/irq-st.h
> > new file mode 100644
> > index 0000000..4c59ace
> > --- /dev/null
> > +++ b/include/dt-bindings/interrupt-controller/irq-st.h
> > @@ -0,0 +1,30 @@
> > +/*
> > + *  include/linux/irqchip/irq-st.h
> 
> Copy & Paste?
> 
> Can we please stop adding these pointless filenames all over the
> place? They are useless and wrong in a lot of cases.

Less of a copy and paste and more and a `mv` without fixing up the
file names.  I guess they are silly, but they are rife, so someone must
think they're a good idea. :)

  for file in `find drivers -name *.c`; do head $file | grep "\.c$"; done

> Aside of that, this needs an ack from the DT folks.

I think you'll be lucky.  I haven't seen a DT review for some time
now.  Perhaps, as it's you, this might be different. ;)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines
  2015-01-23 16:39     ` Lee Jones
@ 2015-01-24 11:46       ` Thomas Gleixner
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Gleixner @ 2015-01-24 11:46 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, kernel, jason, devicetree

On Fri, 23 Jan 2015, Lee Jones wrote:
> On Fri, 23 Jan 2015, Thomas Gleixner wrote:
> > Can we please stop adding these pointless filenames all over the
> > place? They are useless and wrong in a lot of cases.
> 
> Less of a copy and paste and more and a `mv` without fixing up the
> file names.  I guess they are silly, but they are rife, so someone must
> think they're a good idea. :)

I'd rather say they are ripe for being banned :)

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices
  2015-01-23 16:32     ` Lee Jones
@ 2015-01-24 11:48       ` Thomas Gleixner
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Gleixner @ 2015-01-24 11:48 UTC (permalink / raw)
  To: Lee Jones; +Cc: linux-arm-kernel, linux-kernel, kernel, jason, devicetree

On Fri, 23 Jan 2015, Lee Jones wrote:
> On Fri, 23 Jan 2015, Thomas Gleixner wrote:
> > The only technical comment I have is: shouldn't all the stuff except
> > the resume function be marked __init or is any of this required post
> > init?
> 
> It's not common to mark functions invoked at and affter *_probe() as
> __init.  At least, not as far as I'm aware.

Right, if the probe stuff is supposed to be functional post init, then
we of course need to keep it around. But I guess we have no mechanism
to distinguish the 'boot only' and 'keep post init' case. Might be
worthwhile to investigate.

Thanks,

	tglx



^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2015-01-24 11:49 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
2015-01-23 15:58   ` Thomas Gleixner
2015-01-23 16:39     ` Lee Jones
2015-01-24 11:46       ` Thomas Gleixner
2015-01-22  9:48 ` [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices Lee Jones
2015-01-23 16:10   ` Thomas Gleixner
2015-01-23 16:32     ` Lee Jones
2015-01-24 11:48       ` Thomas Gleixner
2015-01-22  9:48 ` [PATCH v2 RESEND 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 5/8] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 7/8] ARM: STi: STiH407: Enable PMU IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).