LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@stlinux.com,
	jason@lakedaemon.net, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices
Date: Sat, 24 Jan 2015 12:48:51 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1501241246240.5526@nanos> (raw)
In-Reply-To: <20150123163231.GB11745@x1>

On Fri, 23 Jan 2015, Lee Jones wrote:
> On Fri, 23 Jan 2015, Thomas Gleixner wrote:
> > The only technical comment I have is: shouldn't all the stuff except
> > the resume function be marked __init or is any of this required post
> > init?
> 
> It's not common to mark functions invoked at and affter *_probe() as
> __init.  At least, not as far as I'm aware.

Right, if the probe stuff is supposed to be functional post init, then
we of course need to keep it around. But I guess we have no mechanism
to distinguish the 'boot only' and 'keep post init' case. Might be
worthwhile to investigate.

Thanks,

	tglx



  reply	other threads:[~2015-01-24 11:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  9:48 [PATCH v2 RESEND 0/8] irqchip: New driver for ST's SysCfg controlled IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Lee Jones
2015-01-23 15:58   ` Thomas Gleixner
2015-01-23 16:39     ` Lee Jones
2015-01-24 11:46       ` Thomas Gleixner
2015-01-22  9:48 ` [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices Lee Jones
2015-01-23 16:10   ` Thomas Gleixner
2015-01-23 16:32     ` Lee Jones
2015-01-24 11:48       ` Thomas Gleixner [this message]
2015-01-22  9:48 ` [PATCH v2 RESEND 3/8] irqchip: irq-st: Add documentation for STi based syscfg IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 4/8] ARM: STi: STiH416: Enable Cortex-A9 PMU support Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 5/8] ARM: STi: STiH416: Enable PMU IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 6/8] ARM: STi: STiH407: Enable Cortex-A9 PMU support Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 7/8] ARM: STi: STiH407: Enable PMU IRQs Lee Jones
2015-01-22  9:48 ` [PATCH v2 RESEND 8/8] ARM: STI: Ensure requested STi's SysCfg Controlled IRQs are enabled at boot Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1501241246240.5526@nanos \
    --to=tglx@linutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel@stlinux.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).