LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Scot Doyle <lkml14@scotdoyle.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	Ashley Lai <ashley@ashleylai.com>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	josh@joshtriplett.org, christophe.ricard@gmail.com,
	jason.gunthorpe@obsidianresearch.com, stefanb@linux.vnet.ibm.com,
	linux-api@vger.kernel.org, trousers-tech@lists.sourceforge.net
Subject: Re: [PATCH v2] tpm: fix suspend/resume paths for TPM 2.0
Date: Thu, 29 Jan 2015 18:43:12 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.11.1501291832460.1678@localhost.localdomain> (raw)
In-Reply-To: <1422510227-23256-1-git-send-email-jarkko.sakkinen@linux.intel.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1386 bytes --]

On Thu, 29 Jan 2015, Jarkko Sakkinen wrote:
> Fixed suspend/resume paths for TPM 2.0 and consolidated all the
> associated code to the tpm_pm_suspend() and tpm_pm_resume()
> functions. Resume path should be handled by the firmware, i.e.
> Startup(CLEAR) for hibernate and Startup(STATE) for suspend.
> 
> There might be some non-PC embedded devices in the future where
> Startup() is not the handled by the FW but fixing the code for
> those IMHO should be postponed until there is hardware available
> to test the fixes although extra Startup in the driver code is
> essentially a NOP.
> 
> Added Shutdown(CLEAR) to the remove paths of TIS and CRB drivers.
> Changed tpm2_shutdown() to a void function because there isn't
> much you can do except print an error message if this fails with
> a system error.
> 
> Reported-by: Peter Hüwe <PeterHuewe@gmx.de>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> ---
>  drivers/char/tpm/tpm-interface.c |  6 ++++--
>  drivers/char/tpm/tpm.h           |  2 +-
>  drivers/char/tpm/tpm2-cmd.c      | 19 +++++++++++--------
>  drivers/char/tpm/tpm_crb.c       | 20 +++++---------------
>  drivers/char/tpm/tpm_tis.c       | 26 +++++++++++++-------------
>  5 files changed, 34 insertions(+), 39 deletions(-)

Resume still functions on TPM 1.2 chip, with and without CONFIG_TCG_CRB.

Tested-by: Scot Doyle <lkml14@scotdoyle.com>

  reply	other threads:[~2015-01-29 18:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29  5:43 Jarkko Sakkinen
2015-01-29 18:43 ` Scot Doyle [this message]
2015-02-02 19:20   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1501291832460.1678@localhost.localdomain \
    --to=lkml14@scotdoyle.com \
    --cc=ashley@ashleylai.com \
    --cc=christophe.ricard@gmail.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jason.gunthorpe@obsidianresearch.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=trousers-tech@lists.sourceforge.net \
    --subject='Re: [PATCH v2] tpm: fix suspend/resume paths for TPM 2.0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).