LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Sujeev Dias <sdias@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Sujeev Dias <sdias@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Tony Truong <truong@codeaurora.org>,
kbuild-all@01.org
Subject: [PATCH] mhi_bus: core: fix memdup.cocci warnings
Date: Sat, 28 Apr 2018 09:23:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1804280922250.2700@hadrien> (raw)
From: Fengguang Wu <fengguang.wu@intel.com>
Use kmemdup rather than duplicating its implementation
Generated by: scripts/coccinelle/api/memdup.cocci
Fixes: ec8245f7a36f ("mhi_bus: core: Add support for MHI host interface")
CC: Sujeev Dias <sdias@codeaurora.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
url:
https://github.com/0day-ci/linux/commits/Sujeev-Dias/mhi_bus-core-Add-support-for-MHI-host-interface/20180428-065959
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
mhi_boot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/bus/mhi/core/mhi_boot.c
+++ b/drivers/bus/mhi/core/mhi_boot.c
@@ -504,7 +504,7 @@ void mhi_fw_load_worker(struct work_stru
if (size > firmware->size)
size = firmware->size;
- buf = kmalloc(size, GFP_KERNEL);
+ buf = kmemdup(firmware->data, size, GFP_KERNEL);
if (!buf) {
MHI_ERR("Could not allocate memory for image\n");
release_firmware(firmware);
@@ -512,7 +512,6 @@ void mhi_fw_load_worker(struct work_stru
}
/* load sbl image */
- memcpy(buf, firmware->data, size);
ret = mhi_fw_load_sbl(mhi_cntrl, buf, size);
kfree(buf);
reply other threads:[~2018-04-28 7:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1804280922250.2700@hadrien \
--to=julia.lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdias@codeaurora.org \
--cc=truong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).