LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings
@ 2019-05-13  7:30 Amelie Delaunay
  2019-05-13  7:44 ` Lee Jones
  2019-05-13  8:59 ` Julia Lawall
  0 siblings, 2 replies; 3+ messages in thread
From: Amelie Delaunay @ 2019-05-13  7:30 UTC (permalink / raw)
  To: Lee Jones, Linus Walleij, Alexandre Torgue, Maxime Coquelin
  Cc: linux-gpio, linux-kernel, linux-arm-kernel, linux-stm32,
	kbuild-all, Julia Lawall, Amelie Delaunay

This patch fixes the following warnings:

drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression
compared with zero: dir < 0
drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression
compared with zero: pupd < 0
drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression
compared with zero: type < 0

Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 drivers/pinctrl/pinctrl-stmfx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index bcd8126..3bd5d6f 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev,
 	struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
 	u32 param = pinconf_to_config_param(*config);
 	struct pinctrl_gpio_range *range;
-	u32 dir, type, pupd;
+	int dir, type, pupd;
 	u32 arg = 0;
 	int ret;
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings
  2019-05-13  7:30 [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings Amelie Delaunay
@ 2019-05-13  7:44 ` Lee Jones
  2019-05-13  8:59 ` Julia Lawall
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2019-05-13  7:44 UTC (permalink / raw)
  To: Amelie Delaunay
  Cc: Linus Walleij, Alexandre Torgue, Maxime Coquelin, linux-gpio,
	linux-kernel, linux-arm-kernel, linux-stm32, kbuild-all,
	Julia Lawall

On Mon, 13 May 2019, Amelie Delaunay wrote:

> This patch fixes the following warnings:
> 
> drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression
> compared with zero: dir < 0
> drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression
> compared with zero: pupd < 0
> drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression
> compared with zero: type < 0
> 
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>  drivers/pinctrl/pinctrl-stmfx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Already fixed up and pushed.

> diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
> index bcd8126..3bd5d6f 100644
> --- a/drivers/pinctrl/pinctrl-stmfx.c
> +++ b/drivers/pinctrl/pinctrl-stmfx.c
> @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev,
>  	struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
>  	u32 param = pinconf_to_config_param(*config);
>  	struct pinctrl_gpio_range *range;
> -	u32 dir, type, pupd;
> +	int dir, type, pupd;
>  	u32 arg = 0;
>  	int ret;
>  

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings
  2019-05-13  7:30 [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings Amelie Delaunay
  2019-05-13  7:44 ` Lee Jones
@ 2019-05-13  8:59 ` Julia Lawall
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-05-13  8:59 UTC (permalink / raw)
  To: Amelie Delaunay
  Cc: Lee Jones, Linus Walleij, Alexandre Torgue, Maxime Coquelin,
	linux-gpio, linux-kernel, linux-arm-kernel, linux-stm32,
	kbuild-all, Julia Lawall



On Mon, 13 May 2019, Amelie Delaunay wrote:

> This patch fixes the following warnings:
>
> drivers/pinctrl/pinctrl-stmfx.c:225:5-8: WARNING: Unsigned expression
> compared with zero: dir < 0
> drivers/pinctrl/pinctrl-stmfx.c:231:5-9: WARNING: Unsigned expression
> compared with zero: pupd < 0
> drivers/pinctrl/pinctrl-stmfx.c:228:5-9: WARNING: Unsigned expression
> compared with zero: type < 0
>
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
>  drivers/pinctrl/pinctrl-stmfx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
> index bcd8126..3bd5d6f 100644
> --- a/drivers/pinctrl/pinctrl-stmfx.c
> +++ b/drivers/pinctrl/pinctrl-stmfx.c
> @@ -213,7 +213,7 @@ static int stmfx_pinconf_get(struct pinctrl_dev *pctldev,
>  	struct stmfx_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
>  	u32 param = pinconf_to_config_param(*config);
>  	struct pinctrl_gpio_range *range;
> -	u32 dir, type, pupd;
> +	int dir, type, pupd;
>  	u32 arg = 0;
>  	int ret;
>
> --
> 2.7.4
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-13  9:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13  7:30 [PATCH] pinctrl: stmfx: Fix comparison of unsigned expression warnings Amelie Delaunay
2019-05-13  7:44 ` Lee Jones
2019-05-13  8:59 ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).