From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbeCWTiT (ORCPT ); Fri, 23 Mar 2018 15:38:19 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42198 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbeCWTiS (ORCPT ); Fri, 23 Mar 2018 15:38:18 -0400 Date: Fri, 23 Mar 2018 20:38:09 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: Shakeel Butt , Dave Hansen , LKML , Linux MM , linuxram@us.ibm.com, mpe@ellerman.id.au, Ingo Molnar , Andrew Morton , shuah@kernel.org Subject: Re: [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC In-Reply-To: Message-ID: References: <20180323180903.33B17168@viggo.jf.intel.com> <20180323180911.E43ACAB8@viggo.jf.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Mar 2018, Dave Hansen wrote: > On 03/23/2018 12:15 PM, Shakeel Butt wrote: > >> We had a check for PROT_READ/WRITE, but it did not work > >> for PROT_NONE. This entirely removes the PROT_* checks, > >> which ensures that PROT_NONE now works. > >> > >> Reported-by: Shakeel Butt > >> Signed-off-by: Dave Hansen > > Should there be a 'Fixes' tag? Also should this patch go to stable? > > There could be, but I'm to lazy to dig up the original commit. Does it > matter? > > And, yes, I think it probably makes sense for -stable. I'll add that if > I resend this series. The fixes tag makes sense in general even if the patch is not tagged for stable. It gives you immediate context and I use it a lot to look why this went unnoticed or what the context of that change was. Thanks, tglx