From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbeDRPKb (ORCPT ); Wed, 18 Apr 2018 11:10:31 -0400 Received: from mail-qt0-f180.google.com ([209.85.216.180]:43819 "EHLO mail-qt0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbeDRPKa (ORCPT ); Wed, 18 Apr 2018 11:10:30 -0400 X-Google-Smtp-Source: AB8JxZpCTc0hoDfFYWrwdyOqTiVg/odeoB8O234ivJe+U0ii8S5Pm/Rf47bX65RXxmfqJFFHUrb29w== From: Vince Weaver X-Google-Original-From: Vince Weaver Date: Wed, 18 Apr 2018 11:10:20 -0400 (EDT) X-X-Sender: vince@macbook-air To: Jiri Olsa cc: Stephane Eranian , LKML , Peter Zijlstra , Arnaldo Carvalho de Melo , mingo@elte.hu, Andi Kleen , Vince Weaver Subject: Re: [RFC] perf/core: what is exclude_idle supposed to do In-Reply-To: <20180417062010.GA2052@krava> Message-ID: References: <20180417062010.GA2052@krava> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Apr 2018, Jiri Olsa wrote: > On Mon, Apr 16, 2018 at 10:04:53PM +0000, Stephane Eranian wrote: > > Hi, > > > > I am trying to understand what the exclude_idle event attribute is supposed > > to accomplish. > > As per the definition in the header file: > > > > exclude_idle : 1, /* don't count when idle */ > > AFAICS it's not implemented so just to be completely clear hear, we're saying that the "exclude_idle" modifier has never done anything useful and still doesn't? If so I should update the perf_event_open manpage to spell this out. Vince