LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL
@ 2019-05-29 17:58 Hariprasad Kelam
  2019-05-29 21:13 ` David Rientjes
  0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2019-05-29 17:58 UTC (permalink / raw)
  To: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel

dont acquire lock before calling wd719x_chip_init.

Issue identified by coccicheck

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
-----
changes in v1: Replace GFP_KERNEL with GFP_ATOMIC.
changes in v2: Call wd719x_chip_init  without lock as suggested
		in review
----
---
 drivers/scsi/wd719x.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index c2f4006..340ec92 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
@@ -505,11 +505,9 @@ static int wd719x_host_reset(struct scsi_cmnd *cmd)
 {
 	struct wd719x *wd = shost_priv(cmd->device->host);
 	struct wd719x_scb *scb, *tmp;
-	unsigned long flags;
 	int result;
 
 	dev_info(&wd->pdev->dev, "host reset requested\n");
-	spin_lock_irqsave(wd->sh->host_lock, flags);
 	/* Try to reinit the RISC */
 	if (wd719x_chip_init(wd) == 0)
 		result = SUCCESS;
@@ -519,7 +517,6 @@ static int wd719x_host_reset(struct scsi_cmnd *cmd)
 	/* flush all SCBs */
 	list_for_each_entry_safe(scb, tmp, &wd->active_scbs, list)
 		wd719x_finish_cmd(scb, result);
-	spin_unlock_irqrestore(wd->sh->host_lock, flags);
 
 	return result;
 }
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL
  2019-05-29 17:58 [Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL Hariprasad Kelam
@ 2019-05-29 21:13 ` David Rientjes
  0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2019-05-29 21:13 UTC (permalink / raw)
  To: Hariprasad Kelam, Ondrej Zary
  Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel

On Wed, 29 May 2019, Hariprasad Kelam wrote:

> dont acquire lock before calling wd719x_chip_init.
> 
> Issue identified by coccicheck
> 
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> -----
> changes in v1: Replace GFP_KERNEL with GFP_ATOMIC.
> changes in v2: Call wd719x_chip_init  without lock as suggested
> 		in review

Why was host_lock taken here initially?  I assume it's to protect some 
race in init that leads to an undefined state.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-29 21:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-29 17:58 [Patch v2] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL Hariprasad Kelam
2019-05-29 21:13 ` David Rientjes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).