LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] xen/pvcalls: backend can be a module
@ 2021-09-07 12:17 Jan Beulich
  2021-09-08  0:49 ` Stefano Stabellini
  2021-09-14  8:04 ` Juergen Gross
  0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2021-09-07 12:17 UTC (permalink / raw)
  To: Juergen Gross, Boris Ostrovsky; +Cc: Stefano Stabellini, lkml, xen-devel

It's not clear to me why only the frontend has been tristate. Switch the
backend to be, too.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -214,7 +214,7 @@ config XEN_PVCALLS_FRONTEND
 	  implements them.
 
 config XEN_PVCALLS_BACKEND
-	bool "XEN PV Calls backend driver"
+	tristate "XEN PV Calls backend driver"
 	depends on INET && XEN && XEN_BACKEND
 	help
 	  Experimental backend for the Xen PV Calls protocol


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen/pvcalls: backend can be a module
  2021-09-07 12:17 [PATCH] xen/pvcalls: backend can be a module Jan Beulich
@ 2021-09-08  0:49 ` Stefano Stabellini
  2021-09-14  8:04 ` Juergen Gross
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2021-09-08  0:49 UTC (permalink / raw)
  To: Jan Beulich
  Cc: Juergen Gross, Boris Ostrovsky, Stefano Stabellini, lkml, xen-devel

On Tue, 7 Sep 2021, Jan Beulich wrote:
> It's not clear to me why only the frontend has been tristate. Switch the
> backend to be, too.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Actually although the frontend is a tristate, it cannot really work as a
module. Specifically see pvcalls_stream_ops in the enabling patch (still
not upstream):

https://github.com/lf-edge/runx/blob/master/kernel/patches/0001-patch-pvcalls_enable.patch


So I had to change tristate to bool for XEN_PVCALLS_FRONTEND in our
internal kernel tree.

That said, the PVCalls backend could very well be a module and
technically I don't see any reasons why not. So:


Acked-by: Stefano Stabellini <sstabellini@kernel.org>



> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -214,7 +214,7 @@ config XEN_PVCALLS_FRONTEND
>  	  implements them.
>  
>  config XEN_PVCALLS_BACKEND
> -	bool "XEN PV Calls backend driver"
> +	tristate "XEN PV Calls backend driver"
>  	depends on INET && XEN && XEN_BACKEND
>  	help
>  	  Experimental backend for the Xen PV Calls protocol
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xen/pvcalls: backend can be a module
  2021-09-07 12:17 [PATCH] xen/pvcalls: backend can be a module Jan Beulich
  2021-09-08  0:49 ` Stefano Stabellini
@ 2021-09-14  8:04 ` Juergen Gross
  1 sibling, 0 replies; 3+ messages in thread
From: Juergen Gross @ 2021-09-14  8:04 UTC (permalink / raw)
  To: Jan Beulich, Boris Ostrovsky; +Cc: Stefano Stabellini, lkml, xen-devel


[-- Attachment #1.1.1: Type: text/plain, Size: 245 bytes --]

On 07.09.21 14:17, Jan Beulich wrote:
> It's not clear to me why only the frontend has been tristate. Switch the
> backend to be, too.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Pushed to xen/tip.git for-linus-5.15


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-14  8:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 12:17 [PATCH] xen/pvcalls: backend can be a module Jan Beulich
2021-09-08  0:49 ` Stefano Stabellini
2021-09-14  8:04 ` Juergen Gross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).