From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49BEAC4338F for ; Tue, 3 Aug 2021 15:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34E2C60243 for ; Tue, 3 Aug 2021 15:00:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236565AbhHCPAR (ORCPT ); Tue, 3 Aug 2021 11:00:17 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:40604 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235773AbhHCPAO (ORCPT ); Tue, 3 Aug 2021 11:00:14 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3Au1HY9K6Kdxj5lZVovAPXwMPXdLJyesId70hD?= =?us-ascii?q?6qkRc202TiX2rauTdZggvyMc6wxhO03I++rgBEDoexq1yXcf2+cs1NmZMDUO9F?= =?us-ascii?q?HJEKhSqbqn+THmFiHkn9Qx6Y5recFFZ+HNMQ=3D=3D?= X-IronPort-AV: E=Sophos;i="5.84,291,1620684000"; d="scan'208";a="389614604" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2021 17:00:02 +0200 Date: Tue, 3 Aug 2021 16:59:55 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, Sumera Priyadarsini Subject: [PATCH] powerpc/kexec: fix for_each_child.cocci warning Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot for_each_node_by_type should have of_node_put() before return. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Sumera Priyadarsini Reported-by: kernel test robot Signed-off-by: kernel test robot --- The code seems to have been this way since the beginning of time. Perhaps the of_node_put is a no op for this code? core_64.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/arch/powerpc/kexec/core_64.c +++ b/arch/powerpc/kexec/core_64.c @@ -64,8 +64,10 @@ int default_machine_kexec_prepare(struct begin = image->segment[i].mem; end = begin + image->segment[i].memsz; - if ((begin < high) && (end > low)) + if ((begin < high) && (end > low)) { + of_node_put(node); return -ETXTBSY; + } } }