LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Cal Peake <cp@absolutedigital.net>
Cc: Chuck Ebbert <cebbert@redhat.com>,
	Gabriel C <nix.or.die@googlemail.com>,
	Frank Hale <frankhale@gmail.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kernel ACPI Mailing List <linux-acpi@vger.kernel.org>,
	len.brown@intel.com, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: ACPI on Averatec 2370
Date: Thu, 2 Aug 2007 14:07:15 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0708021353320.8184@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708021627590.28012@lancer.cnet.absolutedigital.net>



On Thu, 2 Aug 2007, Cal Peake wrote:
> 
> Figured I should have sent that right after I hit the send key...
> 
> processor	: 0
> vendor_id	: AuthenticAMD
> cpu family	: 15
> model		: 72
> model name	: AMD Turion(tm) 64 X2 Mobile Technology TL-52

Sadly, this doesn't show the "extended family" stuff from cpuid.

So it doesn't show any of the bits we actually care about. Sad.

That said, the "AMD Turion(tm) 64 X2 Mobile Technology TL-52" _should_ be 
a REV-F CPU afaik, and it should have thus fallen through to the 
"ENABLE_C1E_MASK" logic. Afaik that's broken.

Cal - can you
 (a) test that forcing a "return 1" from that amd_apic_timer_broken() 
     function fixes it for you.
 (b) make that function print out the values it uses for debugging (ie the 
     xtended family and model numbers, and the MSR_K8_ENABLE_C1E MSR 
     values)?

Andi, can you check with your AMD contacts that those bits are correct.. 
Maybe the "Mobile Technology" things *always* have the broken "Enhanced 
Halt State", regardless of any MSR settings? That would perhaps be what 
makes them "Mobile".

		Linus

  parent reply	other threads:[~2007-08-02 21:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-29 18:05 Frank Hale
2007-07-29 18:13 ` Gabriel C
2007-07-29 18:45   ` Cal Peake
2007-07-29 18:58     ` Frank Hale
2007-07-29 19:58       ` Frank Hale
2007-07-30 15:20   ` Cal Peake
2007-08-02 17:50     ` Cal Peake
2007-08-02 19:09       ` Chuck Ebbert
2007-08-02 19:42         ` Cal Peake
2007-08-02 20:26           ` Chuck Ebbert
2007-08-02 20:30             ` Cal Peake
2007-08-02 20:51               ` Frank Hale
2007-08-02 21:07               ` Linus Torvalds [this message]
2007-08-02 21:53                 ` Cal Peake
2007-08-03 21:56                   ` Linus Torvalds
2007-08-04  9:30                     ` Andi Kleen
2007-08-04 13:50                       ` Frank Hale
2007-08-05 14:26                       ` Thomas Renninger
2007-08-07 22:15                     ` Cal Peake
2007-08-08  0:06                       ` Andi Kleen
2007-08-08  0:53                         ` [PATCH] drop unneeded variable in amd_apic_timer_broken Cal Peake
2007-08-08 14:36                           ` Andi Kleen
2007-08-08 16:00                             ` Cal Peake
2007-08-08 18:25                               ` Tim Gardner
2007-08-08 14:41                         ` ACPI on Averatec 2370 Joachim Deguara
2007-08-08 23:52                           ` Frank Hale
2007-08-09  9:45                             ` Joachim Deguara
2007-08-03 15:52                 ` Ben Collins
2007-08-03 18:19                   ` Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0708021353320.8184@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=cebbert@redhat.com \
    --cc=cp@absolutedigital.net \
    --cc=frankhale@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nix.or.die@googlemail.com \
    --cc=tglx@linutronix.de \
    --subject='Re: ACPI on Averatec 2370' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).