LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Pavel Machek <pavel@ucw.cz>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION
Date: Fri, 3 Aug 2007 15:01:44 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0708031459090.8184@woody.linux-foundation.org> (raw)
In-Reply-To: <200708032359.37677.rjw@sisk.pl>



On Fri, 3 Aug 2007, Rafael J. Wysocki wrote:
>  	depends on PM
> -	depends on !SMP || SUSPEND_SMP_POSSIBLE
> +	depends on SUSPEND_SMP_POSSIBLE || ((BLACKFIN || MIPS || SUPERH || FRV \
> +		    || (PPC32 && PPC_MPC52xx)) && !SMP)

Please, do that as SUSPEND_UP_POSSIBLE, and make it look like

	config SUSPEND_UP_POSSIBLE
		depends on BLACKFIN || MIPS || SUPERH || FRV || ((PPC32 && PPC_MPC52xx)
		depends on !SMP
		default y

and now you can write the above thing as

	depends on SUSPEND_SMP_POSSIBLE || SUSPEND_UP_POSSIBLE

and it's all much nicer.

I would say that doing a similar setup for HIBERNATE would be nice too, 
but the SUSPEND case is more noticeable because the SMP case is so nice 
already.

		Linus

  reply	other threads:[~2007-08-03 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 21:59 Rafael J. Wysocki
2007-08-03 22:01 ` Linus Torvalds [this message]
2007-08-03 22:47   ` Rafael J. Wysocki
2007-08-04  3:45     ` Len Brown
2007-08-04  9:48       ` Rafael J. Wysocki
2007-08-04 22:09         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0708031459090.8184@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --subject='Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).