LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>,
	Jan Beulich <jbeulich@novell.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	Roman Zippel <zippel@linux-m68k.org>
Cc: rdunlap@xenotime.net,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.23-git Kconfig regression
Date: Fri, 19 Oct 2007 21:25:55 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.0.999.0710192121140.3794@woody.linux-foundation.org> (raw)
In-Reply-To: <20071020041140.0E41423A734@adsl-69-226-248-13.dsl.pltn13.pacbell.net>



On Fri, 19 Oct 2007, David Brownell wrote:

> > My (quick, meaning that I may have missed something) testing
> > indicates that the problem is in the patches attached.
> 
> Yes, reverting this seems to resolve the problem:
> 
> > a5bf3d891a6a0fb5aa122792d965e3774108b923
> >
> > Change kconfig behavior so that mixing bool and tristate config settings in
> > a choice is possible and has the desired effect of offering just the
> > tristate options individually if the choice gets set to M, and a normal
> > boolean selection if the choice gets set to Y.
> 
> Reverting this patch also fixes a second problem that I didn't
> mention:  various dependent options couldn't be enabled.
> 
> Again in drivers/usb/gadget/Kconfig, examples include the
> ability to configure the Ethernet gadget to act as an RNDIS
> peripheral; or enabling Mass Storage gadget debug options.
> 
> 
> Good sleuthing, and thanks!
> 
> Now we just need to see that patch reverted before RC1... I don't
> know how Linus deals with all his LKML mail, so I cc'd him in
> the hope that direct messages get through a bit faster.

Ok, I'll revert it, but wanted to make sure that the parties that pushed 
the change are aware of this.

		Linus 

  reply	other threads:[~2007-10-20  4:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20  1:22 David Brownell
2007-10-20  1:46 ` Randy Dunlap
2007-10-20  1:57   ` David Brownell
2007-10-20  2:01     ` Randy Dunlap
2007-10-20  2:55       ` Randy Dunlap
2007-10-20  3:21         ` Randy Dunlap
2007-10-20  4:11           ` David Brownell
2007-10-20  4:25             ` Linus Torvalds [this message]
2007-10-20 16:50               ` Sam Ravnborg
2008-01-16  9:29           ` Jan Beulich
2008-01-17  0:02             ` David Brownell
2008-01-17  8:16               ` Jan Beulich
2008-01-17  8:32                 ` David Brownell
2007-10-20 18:27 Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.999.0710192121140.3794@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sam@ravnborg.org \
    --cc=zippel@linux-m68k.org \
    --subject='Re: 2.6.23-git Kconfig regression' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).