LKML Archive on
help / color / mirror / Atom feed
From: Linus Torvalds <>
To: Matthew Wilcox <>
Cc: James Bottomley <>,
	Al Viro <>,,
Subject: Re: Sparse fix for scsi_request_fn
Date: Mon, 22 Oct 2007 19:09:56 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 22 Oct 2007, Matthew Wilcox wrote:
> Introduce new __holds() macro to tell sparse it's OK to drop and then
> reacquire a lock within a function.  Use it in scsi_request_fn.

Umm. This is why we write things like

	static void double_lock_balance(struct rq *this_rq, struct rq *busiest)

ie your "__holds()" is nothing new, and should be written as 
a pair of __releases(x) and __acquires(x), which is more readable anyway 
(since it actually says what the function does!)


  reply	other threads:[~2007-10-23  2:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23  1:48 Matthew Wilcox
2007-10-23  2:09 ` Linus Torvalds [this message]
2007-10-23 21:13   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: Sparse fix for scsi_request_fn' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).