LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Julia Lawall <julia@diku.dk>
Cc: khali@linux-fr.org, i2c@lm-sensors.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
Date: Tue, 13 Nov 2007 16:34:58 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.0.9999.0711131632490.26111@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0711132231080.18337@ask.diku.dk>

On Tue, 13 Nov 2007, Julia Lawall wrote:

> Send to:
> khali@linux-fr.org,
> i2c@lm-sensors.org,
> linux-kernel@vger.kernel.org,
> kernel-janitors@vger.kernel.org
>
> Subject: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h
>
>
> ------------------------------------------------------
>
> From: Julia Lawall <julia@diku.dk>
>
> Drop #include <linux/moduleparam.h> in files that also include #include
> <linux/module.h>.  module.h includes moduleparam.h already.

i'm not convinced that's a good idea.  while module.h does currently
(and unfortunately) include moduleparam.h, there may come a day when
those header files are refactored to actually make sense, at which
point all those missing moduleparam.h inclusions will cause all sorts
of bad things to happen.

rday

p.s.  i tried that cleanup once.  it got ugly in a hurry.

--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

  reply	other threads:[~2007-11-13 21:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13 21:32 Julia Lawall
2007-11-13 21:34 ` Robert P. J. Day [this message]
2007-11-14  6:09   ` Julia Lawall
2007-11-14  9:21     ` Robert P. J. Day
2007-11-15 12:19       ` Jean Delvare
2007-11-15 12:42         ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.0.9999.0711131632490.26111@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=i2c@lm-sensors.org \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).