LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Anton Salikhmetov <salikhmetov@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
peterz@infradead.org, linux-mm@kvack.org, jakob@unthought.net,
linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu,
riel@redhat.com, ksm@42.dk, staubach@redhat.com,
jesper.juhl@gmail.com, akpm@linux-foundation.org,
protasnb@gmail.com, r.e.wolff@bitwizard.nl,
hidave.darkstar@gmail.com, hch@infradead.org
Subject: Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files
Date: Fri, 18 Jan 2008 13:27:07 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.1.00.0801181325510.2957@woody.linux-foundation.org> (raw)
In-Reply-To: <4df4ef0c0801181303o6656832g8b63d2a119a86a9c@mail.gmail.com>
On Sat, 19 Jan 2008, Anton Salikhmetov wrote:
>
> Before using pte_wrprotect() the vma_wrprotect() routine uses the
> pte_offset_map_lock() macro to get the PTE and to acquire the ptl
> spinlock. Why did you say that this code was not SMP-safe? It should
> be atomic, I think.
It's atomic WITH RESPECT TO OTHER PEOPLE WHO GET THE LOCK.
Guess how much another x86 CPU cares when it sets the accessed bit in
hardware?
> The POSIX standard requires the ctime and mtime stamps to be updated
> not later than at the second call to msync() with the MS_ASYNC flag.
.. and that is no excuse for bad code.
Linus
next prev parent reply other threads:[~2008-01-18 21:28 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 22:31 [PATCH -v6 0/2] Fixing the issue with memory-mapped file times Anton Salikhmetov
2008-01-17 22:31 ` [PATCH -v6 1/2] Massive code cleanup of sys_msync() Anton Salikhmetov
2008-01-18 9:33 ` Miklos Szeredi
2008-01-18 10:30 ` Anton Salikhmetov
2008-01-17 22:31 ` [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files Anton Salikhmetov
2008-01-18 9:51 ` Miklos Szeredi
2008-01-18 10:15 ` Peter Zijlstra
2008-01-18 10:25 ` Peter Zijlstra
2008-01-18 10:39 ` Anton Salikhmetov
2008-01-18 17:58 ` Linus Torvalds
2008-01-18 18:11 ` Miklos Szeredi
2008-01-18 18:28 ` Rik van Riel
2008-01-18 18:51 ` Miklos Szeredi
2008-01-18 18:43 ` Linus Torvalds
2008-01-18 18:57 ` Miklos Szeredi
2008-01-18 19:08 ` Linus Torvalds
2008-01-18 19:22 ` Miklos Szeredi
2008-01-18 19:35 ` Linus Torvalds
2008-01-18 19:58 ` Anton Salikhmetov
2008-01-18 20:22 ` Linus Torvalds
2008-01-18 21:03 ` Anton Salikhmetov
2008-01-18 21:27 ` Linus Torvalds [this message]
2008-01-18 22:04 ` Anton Salikhmetov
2008-01-18 22:21 ` Linus Torvalds
2008-01-18 22:35 ` Anton Salikhmetov
2008-01-18 22:32 ` Ingo Oeser
2008-01-18 22:47 ` Linus Torvalds
2008-01-18 22:54 ` Rik van Riel
2008-01-19 0:50 ` Matt Mackall
2008-01-19 4:25 ` Rik van Riel
2008-01-19 10:22 ` Miklos Szeredi
2008-01-19 15:49 ` Matt Mackall
2008-01-21 14:25 ` Peter Staubach
2008-01-21 14:36 ` Anton Salikhmetov
2008-01-18 10:38 ` Miklos Szeredi
2008-01-18 11:00 ` Peter Zijlstra
2008-01-18 11:17 ` Miklos Szeredi
2008-01-18 11:23 ` Peter Zijlstra
2008-01-18 11:36 ` Miklos Szeredi
2008-01-18 9:40 ` [PATCH -v6 0/2] Fixing the issue with memory-mapped file times Miklos Szeredi
2008-01-18 10:31 ` Anton Salikhmetov
2008-01-18 19:48 ` Anton Salikhmetov
2008-01-19 10:45 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0801181325510.2957@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hidave.darkstar@gmail.com \
--cc=jakob@unthought.net \
--cc=jesper.juhl@gmail.com \
--cc=ksm@42.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=peterz@infradead.org \
--cc=protasnb@gmail.com \
--cc=r.e.wolff@bitwizard.nl \
--cc=riel@redhat.com \
--cc=salikhmetov@gmail.com \
--cc=staubach@redhat.com \
--cc=valdis.kletnieks@vt.edu \
--subject='Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).