LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Harald Arnesen <skogtun.linux@gmail.com>
Cc: FUJITA Tomonori <tomof@acm.org>,
	akpm@linux-foundation.org, matthew@wil.cx,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	fujita.tomonori@lab.ntt.co.jp
Subject: Re: Latest git oopses during boot
Date: Thu, 7 Feb 2008 13:14:25 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802071304420.2896@woody.linux-foundation.org> (raw)
In-Reply-To: <8120cfd40802071248x20ed938dh52cd9e314219613b@mail.gmail.com>



On Thu, 7 Feb 2008, Harald Arnesen wrote:
> >
> > Can you do a
> >
> >         make drivers/scsi/advansys.lst
> >
> > and see what it should be?
> 
> Anyway, here it is, as an attachment.

Ok, I was wrong. The code really *does* compile to that insane

	a3 14 00 00 00          mov    %eax,0x14

by your compiler.

That's the

	asc_dvc_varp->overrun_buf = kzalloc(ASC_OVERRUN_BSIZE, GFP_KERNEL);

thing, and gcc seems to have decided that it can statically prove that 
asc_dvc_varp is NULL.

Quite frankly, I don't see that being true. But you have some patches in 
your tree that I haven't followed, so.. Are you sure the patches applied 
to the right spot? The patch I saw added that kzalloc() to the _end_ of 
the function (long after asc_dvc_varp was initialized), maybe that one got 
mis-applied?

Or maybe your compiler version is simply totally broken.

			Linus

  parent reply	other threads:[~2008-02-07 21:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 16:32 Harald Arnesen
2008-02-06 22:47 ` Andrew Morton
     [not found]   ` <8120cfd40802070144l79830c2cs6329c302697ecc8b@mail.gmail.com>
2008-02-07 10:02     ` Andrew Morton
2008-02-07 11:14       ` Harald Arnesen
2008-02-07 11:16         ` Christoph Hellwig
2008-02-07 14:32         ` FUJITA Tomonori
     [not found]           ` <8120cfd40802070933r42a98537v78feb7ee8e748a94@mail.gmail.com>
2008-02-07 18:18             ` Linus Torvalds
     [not found]               ` <8120cfd40802071248x20ed938dh52cd9e314219613b@mail.gmail.com>
2008-02-07 21:14                 ` Linus Torvalds [this message]
2008-02-07 21:39                   ` Harald Arnesen
2008-02-07 22:12                     ` Linus Torvalds
2008-02-07 22:24                       ` Harald Arnesen
2008-02-08  0:10                         ` FUJITA Tomonori
2008-02-06 23:06 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802071304420.2896@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=skogtun.linux@gmail.com \
    --cc=tomof@acm.org \
    --subject='Re: Latest git oopses during boot' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).