From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934225AbYBGWNW (ORCPT ); Thu, 7 Feb 2008 17:13:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760730AbYBGWNK (ORCPT ); Thu, 7 Feb 2008 17:13:10 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50154 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755717AbYBGWNI (ORCPT ); Thu, 7 Feb 2008 17:13:08 -0500 Date: Thu, 7 Feb 2008 14:12:54 -0800 (PST) From: Linus Torvalds To: Harald Arnesen cc: Harald Arnesen , FUJITA Tomonori , akpm@linux-foundation.org, matthew@wil.cx, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp Subject: Re: Latest git oopses during boot In-Reply-To: <87hcgkzbry.fsf@basilikum.skogtun.org> Message-ID: References: <8120cfd40802070144l79830c2cs6329c302697ecc8b@mail.gmail.com> <20080207020214.0f0cf1c7.akpm@linux-foundation.org> <8120cfd40802070314x2799bcbatf42e3fe824a18c22@mail.gmail.com> <20080207233239Z.tomof@acm.org> <8120cfd40802070933r42a98537v78feb7ee8e748a94@mail.gmail.com> <8120cfd40802071248x20ed938dh52cd9e314219613b@mail.gmail.com> <87hcgkzbry.fsf@basilikum.skogtun.org> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Feb 2008, Harald Arnesen wrote: > > I'll try applying the patch to a freshly downloaded git-tree. Ok, good. > Shall I try another compiler? I have at least these two: > > gcc version 3.4.6 (Ubuntu 3.4.6-6ubuntu2) > gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2) I would suggest a patch mis-application problem first (or possibly even the patch itself being broken - I simply didn't look very closely at the patch, but it *looked* ok). If it's a compiler bug, it's a pretty big one, and quite frankly, I doubt it. Compiler bugs do happen, but they are pretty rare, and they tend to have more subtle effects than the one you see. However: > in addition to the self-compiled 4.2.3 I used for the tests. 4.2.3? Really? That's pretty damn recent, and so almost totally untested. That does make a compiler bug at least more likely. So yes, if you already have other compilers installed, you should try them. If it really is a compiler bug, it's a really bad one, and you would want to let the gcc people know. Still, I'd double-check that the asc_dvc_varp->overrun_buf = kzalloc(ASC_OVERRUN_BSIZE, GFP_KERNEL); line was added properly first. You should see it way after the point where it did asc_dvc_varp = &boardp->dvc_var.asc_dvc_var; to initialize it (and both statements should be inside a if (ASC_NARROW_BOARD(boardp)) { conditional - please check that the source code looks sane too). Linus